From owner-freebsd-stable@FreeBSD.ORG  Wed Apr 30 13:14:11 2008
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 53F251065670
	for <stable@freebsd.org>; Wed, 30 Apr 2008 13:14:11 +0000 (UTC)
	(envelope-from oliver@FreeBSD.org)
Received: from avocado.salatschuessel.net (avocado.salatschuessel.net
	[83.136.81.184]) by mx1.freebsd.org (Postfix) with SMTP id A0F8F8FC1B
	for <stable@freebsd.org>; Wed, 30 Apr 2008 13:14:10 +0000 (UTC)
	(envelope-from oliver@FreeBSD.org)
Received: (qmail 39037 invoked by uid 89); 30 Apr 2008 13:14:07 -0000
Received: from unknown (HELO kartoffel.salatschuessel.net) (83.136.81.185)
	by avocado.salatschuessel.net with SMTP; 30 Apr 2008 13:14:07 -0000
Date: Wed, 30 Apr 2008 15:14:02 +0200
From: Oliver Lehmann <oliver@FreeBSD.org>
To: Mike Makonnen <mtm@wubethiopia.com>
Message-Id: <20080430151402.23674a45.oliver@FreeBSD.org>
In-Reply-To: <4817FAC3.3090304@wubethiopia.com>
References: <20080428173019.9741ad41.oliver@FreeBSD.org>
	<4817FAC3.3090304@wubethiopia.com>
X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.9; amd64-portbld-freebsd7.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: stable@freebsd.org
Subject: Re: error in src/etc/rc.d/mountcritlocal
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Apr 2008 13:14:11 -0000

Mike Makonnen wrote:

> I'm not sure what you mean. The checkyesno() routine considers "true" a 
> valid parameter. Could you please post the exact error you're getting.

I already posted it... I'm getting:

$true is not set properly - see rc.conf(5)

This is because:

you call "start_boot true"
start_boot itself calls checkyesno $1 - so it calls "checkyesno true"

checkyesno then defines _value with "eval _value=\$${1}" so _value gets
$true which is not an allowed value.

let me past the comment of checkyesno:

# checkyesno var
#       Test $1 variable, and warn if not set to YES or NO.
#       Return 0 if it's "yes" (et al), nonzero otherwise.

A variablename has to be handed over to checkyesno, not a value like
"true" or "yes" or whatever else. You see the error?

-- 
 Oliver Lehmann
  http://www.pofo.de/
  http://wishlist.ans-netz.de/