From owner-freebsd-stable@FreeBSD.ORG Sat Feb 6 04:45:00 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 335D1106566B; Sat, 6 Feb 2010 04:45:00 +0000 (UTC) (envelope-from ncrogers@gmail.com) Received: from mail-px0-f183.google.com (mail-px0-f183.google.com [209.85.216.183]) by mx1.freebsd.org (Postfix) with ESMTP id E7C678FC0A; Sat, 6 Feb 2010 04:44:59 +0000 (UTC) Received: by pxi13 with SMTP id 13so1867235pxi.3 for ; Fri, 05 Feb 2010 20:44:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=AODE0EaDQc+hXdFoK+/i4hBK4vtWThjIHyuQLH0AQV8=; b=BixhgUDChXU3yhyR5PU275xIkhIY4tHGm6pZP+vs8uSTFUQYx+pC/JPO/9dEAbo6Aq 4vMgXsg4CSK+xjcSagq6IISg6WGa+yvFnPezz3JF78tvK70H3Wfh1q1G6EHxKIZt9/Po 0kcqQP8+t+OgpGfKQhQ3HoJcD8CZ98SQbzSSI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=I5I+NbCXqF+cunzIG6s6+Tw1ar1uEXDEDOqgWM36RzmtdAxNvECqZJ+dAsmxCf87Ok lrD7G1BddrWoxzRxrlmmgIPPjvKonkawRInVGLUzJeNL+Uta0/i1o9wDSx4IkdNJWTNX +hf5Omgq3iW8HSU7gjKxP7MuUmveDBsWyR+ss= MIME-Version: 1.0 Received: by 10.142.55.5 with SMTP id d5mr2371403wfa.11.1265431499321; Fri, 05 Feb 2010 20:44:59 -0800 (PST) In-Reply-To: <201002050351.12270.max@love2party.net> References: <147432021001310037n1b67f01bx4b4e8781321cea8@mail.gmail.com> <2a41acea1002021443t1c298528i2df3cf40269c733@mail.gmail.com> <2a41acea1002021447t1067ee42gc59b25216270459b@mail.gmail.com> <201002050351.12270.max@love2party.net> Date: Fri, 5 Feb 2010 20:44:59 -0800 Message-ID: <147432021002052044h591c4050ka7f39b4ec739f2a@mail.gmail.com> From: Nick Rogers To: Max Laier Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: pyunyh@gmail.com, jfv@freebsd.org, freebsd-stable@freebsd.org, Jack Vogel Subject: Re: em(4) + ALTQ broken X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Feb 2010 04:45:00 -0000 I applied drbr_altq.diff to the e1000 driver (sys/dev/e1000) from HEAD on top of 8.0-RELEASE kernel sources. It appears to have fixed the immediate problem where queues simply don't work on em interfaces. Thanks a bunch. I suppose further review and testing by others would be greatly appreciated from my point of view. I am trying to decide on a relatively stable 8.0 kernel with working em(4) + ALTQ to put into production on 100 or so installations. Are you guys more comfortable with the HEAD sys/dev/e1000 + this patch on top of 8.0-RELEASE, or e1000 from 7.2 on top of 8.0-RELEASE? So far I am having good luck with the later. Thanks again for your contributions! On Thu, Feb 4, 2010 at 6:51 PM, Max Laier wrote: > Okay ... attached is a patch to fix this for em(4) (and lay the groundwork > to > fix it for other drbr_* consumer as well). I have tested it in VirtualBox, > but don't have real hardware to check for non-ALTQ performance or other > regressions. > > Test, comments and review appreciated. > > -- > Max >