From owner-freebsd-bugs@freebsd.org Tue Mar 7 04:42:45 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 539C3D01FC3 for ; Tue, 7 Mar 2017 04:42:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2A8F514C2 for ; Tue, 7 Mar 2017 04:42:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v274gjVk097000 for ; Tue, 7 Mar 2017 04:42:45 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 217602] It is desirable that dot files grow recursive functionality in pw, bsdinstall, etc Date: Tue, 07 Mar 2017 04:42:45 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: imp@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 04:42:45 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217602 Bug ID: 217602 Summary: It is desirable that dot files grow recursive functionality in pw, bsdinstall, etc Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: imp@FreeBSD.org As discussed on IRC with imp, Allan Jude, John Baldwin, and myself... bsdconfig mirrors the actions of pw(8) with respect to skel (please see the pw(8) manual with respect to skeleton files and the effect the `-m' paramet= er has on copying of skel files). At the very least, the suggested change here has to be accompanied by a corresponding change to several other tools, including but not limited to pw(8), adduser(8), and their respective manuals. A patch that implements the bsdinstall part of the change can be found at https://github.com/freebsd/freebsd/pull/98 and it still applies, included inline for your convenience since it is so simple. Also noted in the code review the -R -n should be -Rn (or maybe that was in the IRC conversation). Since this isn't a code snippet ready to commit, redirecting to bugzilla per project policy. This should be assigned to dteske@. usr.sbin/bsdconfig/usermgmt/share/user.subr @@ -145,12 +145,12 @@ f_user_copy_dotfiles() [ -e "$file" ] || continue # no-match f_shell_escape "$file" "_file" - f_eval_catch $funcname cp "cp -n '%s' '%s'" \ + f_eval_catch $funcname cp "cp -R -n '%s' '%s'" \ "$_file" "$_user_home_dir/${_file#dot}" retval=3D$? [ $retval -eq $SUCCESS ] || break f_eval_catch $funcname chown \ - "chown -h '%i:%i' '%s'" \ + "chown -R -h '%i:%i' '%s'" \ "$_user_uid" "$_user_gid" \ "$_user_home_dir/${_file#dot}" retval=3D$? --=20 You are receiving this mail because: You are the assignee for the bug.=