From owner-svn-src-all@freebsd.org Tue Sep 3 14:07:36 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 63EA7DCF79; Tue, 3 Sep 2019 14:06:48 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N7zq5gnlz4Pw5; Tue, 3 Sep 2019 14:06:47 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 8F32A1ABBC; Tue, 3 Sep 2019 14:06:17 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id E15E61A716; Fri, 12 Apr 2019 20:35:43 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5FA638BB3D; Fri, 12 Apr 2019 20:35:43 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 0BA841A6E1; Fri, 12 Apr 2019 20:35:43 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id E2AB71A6C9; Fri, 12 Apr 2019 20:35:39 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from mx0a-00273201.pphosted.com (mx0a-00273201.pphosted.com [208.84.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.pphosted.com", Issuer "Thawte RSA CA 2018" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 842688BB22; Fri, 12 Apr 2019 20:35:39 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from pps.filterd (m0108158.ppops.net [127.0.0.1]) by mx0a-00273201.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3CKYRpr011690; Fri, 12 Apr 2019 13:35:36 -0700 Received: from nam01-bn3-obe.outbound.protection.outlook.com (mail-bn3nam01lp2057.outbound.protection.outlook.com [104.47.33.57]) by mx0a-00273201.pphosted.com with ESMTP id 2rtxt98by4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 12 Apr 2019 13:35:36 -0700 Received: from SN4PR0501CA0045.namprd05.prod.outlook.com (2603:10b6:803:41::22) by DM6PR05MB4187.namprd05.prod.outlook.com (2603:10b6:5:91::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.3; Fri, 12 Apr 2019 20:35:33 +0000 Received: from CO1NAM05FT047.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e50::204) by SN4PR0501CA0045.outlook.office365.com (2603:10b6:803:41::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1792.11 via Frontend Transport; Fri, 12 Apr 2019 20:35:32 +0000 Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.12 as permitted sender) Received: from P-EXFEND-EQX-01.jnpr.net (66.129.239.12) by CO1NAM05FT047.mail.protection.outlook.com (10.152.96.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1792.7 via Frontend Transport; Fri, 12 Apr 2019 20:35:31 +0000 Received: from P-EXBEND-EQX-01.jnpr.net (10.104.8.52) by P-EXFEND-EQX-01.jnpr.net (10.104.8.54) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 12 Apr 2019 13:35:27 -0700 Received: from p-mailhub01.juniper.net (10.104.20.6) by P-EXBEND-EQX-01.jnpr.net (10.104.8.52) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 12 Apr 2019 13:35:27 -0700 Received: from kaos.jnpr.net (kaos.jnpr.net [172.23.50.162]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id x3CKZPMA010039; Fri, 12 Apr 2019 13:35:25 -0700 (envelope-from sjg@juniper.net) Received: by kaos.jnpr.net (Postfix, from userid 1377) id 54D127C8EB; Fri, 12 Apr 2019 13:35:25 -0700 (PDT) Received: from kaos.jnpr.net (localhost [127.0.0.1]) by kaos.jnpr.net (Postfix) with ESMTP id 530B57C8EA; Fri, 12 Apr 2019 13:35:25 -0700 (PDT) To: John Baldwin CC: "Herbert J. Skuhra" , , , , , Subject: Re: svn commit: r346145 - in stable/12: contrib/bearssl etc/mtree include lib lib/libbearssl lib/libsecureboot lib/libsecureboot/tests sbin sbin/veriexec share/mk stand stand/common stand/ficl stand/fi... In-Reply-To: <3b07eef9-ef5a-8925-3d64-bb6f2bcfdc6b@FreeBSD.org> References: <201904120103.x3C1302P053933@repo.freebsd.org> <87o95bf70b.wl-herbert@gojira.at> <14402.1555094583@kaos.jnpr.net> <3b07eef9-ef5a-8925-3d64-bb6f2bcfdc6b@FreeBSD.org> Comments: In-reply-to: John Baldwin message dated "Fri, 12 Apr 2019 12:02:12 -0700." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6+git; nmh 1.7.1; GNU Emacs 26.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <41432.1555101325.1@kaos.jnpr.net> Message-ID: <46386.1555101325@kaos.jnpr.net> X-EXCLAIMER-MD-CONFIG: e3cb0ff2-54e7-4646-8a04-0dae4ac7b136 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:66.129.239.12; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(346002)(39860400002)(376002)(396003)(136003)(2980300002)(199004)(189003)(69596002)(53936002)(68736007)(106466001)(97876018)(316002)(50466002)(105596002)(53416004)(76506005)(7696005)(76176011)(97736004)(54906003)(6916009)(4744005)(336012)(117636001)(50226002)(77096007)(5660300002)(186003)(8936002)(81156014)(16586007)(26005)(11346002)(486006)(476003)(126002)(478600001)(81166006)(305945005)(356004)(47776003)(90966002)(8676002)(446003)(229853002)(7126003)(86362001)(97756001)(9686003)(23726003)(6266002)(107886003)(2906002)(6246003)(4326008)(55016002)(93886005)(46406003); DIR:OUT; SFP:1102; SCL:1; SRVR:DM6PR05MB4187; H:P-EXFEND-EQX-01.jnpr.net; FPR:; SPF:SoftFail; LANG:en; PTR:InfoDomainNonexistent; A:1; MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 88f58370-33de-4dca-550f-08d6bf86686f X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4710095)(4711036)(2017052603328); SRVR:DM6PR05MB4187; X-MS-TrafficTypeDiagnostic: DM6PR05MB4187: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 0005B05917 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: xFvsI8jw+1udm2n670PXAN3q0ux4WHEoCv36AwjMrQm4pn4rtkmDa9EpRHTvnYSw/z2/RP4sUMevRMG2p/jWyhtYIU4sCcXtAZz85UN6i9SNO1UN/pGdM5TAaOsjFOmgff0Vazw1L0wdYf6STQU+CQzT4RiuspKpFRXFH5XG/lnqbw3lPz+yWXNMS9VoDL7KOrgRMDGwavnE4YnBZsJexFzAA6/4NevHYj9j6Zcvn25Y3mR0ImtxL5RLZt1Feoy9XoCgyy7OSZPhm0Dugb7VEafGoGWwR2do/hSR6+5HOfvLbo4q7dQ/zXwmCqSReZbEkb7zT0eZkSo8UNgGv+rvb/8BRNPWZ1W0+MFTBUZ7DGyRYDiCNdlN/pFnfplz6hs00EObtEVVEiPzhizAlc81+0EuY24M3Iz+orpVkHUw3j8= X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2019 20:35:31.6292 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88f58370-33de-4dca-550f-08d6bf86686f X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.12]; Helo=[P-EXFEND-EQX-01.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR05MB4187 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-12_11:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=778 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904120137 Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 5FA638BB3D X-Spamd-Bar: ------ X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.990,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Status: O X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:07:36 -0000 X-Original-Date: Fri, 12 Apr 2019 13:35:25 -0700 X-List-Received-Date: Tue, 03 Sep 2019 14:07:36 -0000 John Baldwin wrote: > > but would it not be more correct to just run makeman ? > > Yes, I would just run makeman and commit the result. Ideally you'd > have included that in the original MFC even, but a followup commit > is fine. I don't think it's really useful to try to MFC the 344853 > change as-is. Done.