From owner-svn-src-head@FreeBSD.ORG  Thu Jun 27 21:20:16 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 6916BB04;
 Thu, 27 Jun 2013 21:20:16 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 by mx1.freebsd.org (Postfix) with ESMTP id 474CF1F45;
 Thu, 27 Jun 2013 21:20:16 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 74580B941;
 Thu, 27 Jun 2013 17:20:15 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Andre Oppermann <andre@freebsd.org>
Subject: Re: svn commit: r252209 - in head: share/man/man9 sys/kern sys/sys
Date: Thu, 27 Jun 2013 10:34:11 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p25; KDE/4.5.5; amd64; ; )
References: <201306251844.r5PIiFDZ009708@svn.freebsd.org>
 <51CA97AE.4090306@freebsd.org>
In-Reply-To: <51CA97AE.4090306@freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201306271034.11852.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Thu, 27 Jun 2013 17:20:15 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Jun 2013 21:20:16 -0000

On Wednesday, June 26, 2013 3:26:38 am Andre Oppermann wrote:
> On 25.06.2013 20:44, John Baldwin wrote:
> > Author: jhb
> > Date: Tue Jun 25 18:44:15 2013
> > New Revision: 252209
> > URL: http://svnweb.freebsd.org/changeset/base/252209
> >
> > Log:
> >    Several improvements to rmlock(9).  Many of these are based on patches
> >    provided by Isilon.
> >    - Add an rm_assert() supporting various lock assertions similar to other
> >      locking primitives.  Because rmlocks track readers the assertions are
> >      always fully accurate unlike rw_assert() and sx_assert().
> >    - Flesh out the lock class methods for rmlocks to support sleeping via
> >      condvars and rm_sleep() (but only while holding write locks), rmlock
> >      details in 'show lock' in DDB, and the lc_owner method used by
> >      dtrace.
> >    - Add an internal destroyed cookie so that API functions can assert
> >      that an rmlock is not destroyed.
> >    - Make use of rm_assert() to add various assertions to the API (e.g.
> >      to assert locks are held when an unlock routine is called).
> >    - Give RM_SLEEPABLE locks their own lock class and always use the
> >      rmlock's own lock_object with WITNESS.
> >    - Use THREAD_NO_SLEEPING() / THREAD_SLEEPING_OK() to disallow sleeping
> >      while holding a read lock on an rmlock.
> 
> Thanks!
> 
> Would it make sense to move struct rm_queue from struct pcpu itself to
> using DPCPU as a next step?

Perhaps.  It might make pcpu.h cleaner, aside from that concern I don't think
it really matters much.

-- 
John Baldwin