From owner-freebsd-current@FreeBSD.ORG Sun May 11 17:49:26 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 90AB3D1C; Sun, 11 May 2014 17:49:26 +0000 (UTC) Received: from FreeBSD.cs.nctu.edu.tw (FreeBSD.cs.nctu.edu.tw [140.113.17.209]) by mx1.freebsd.org (Postfix) with ESMTP id 58A082661; Sun, 11 May 2014 17:49:26 +0000 (UTC) Received: by FreeBSD.cs.nctu.edu.tw (Postfix, from userid 1058) id 8DDBE22CB; Mon, 12 May 2014 01:49:23 +0800 (CST) Date: Mon, 12 May 2014 01:49:23 +0800 From: Li-Wen Hsu To: Warner Losh Subject: Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386 Message-ID: <20140511174923.GA86890@FreeBSD.cs.nctu.edu.tw> References: <254143261.0.1399675169702.JavaMail.jenkins@jenkins-9.freebsd.org> <26E92F41-F849-43E2-AC1F-553F1AB7B11F@bsdimp.com> <24A899DC-E837-4050-964C-4A592C39D8C8@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <24A899DC-E837-4050-964C-4A592C39D8C8@bsdimp.com> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: Craig Rodrigues , freebsd-current Current , "jenkins-admin@freebsd.org" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 May 2014 17:49:26 -0000 On Sat, May 10, 2014 at 20:06:58 -0600, Warner Losh wrote: > > On May 10, 2014, at 8:06 PM, Warner Losh wrote: > > > > > On May 10, 2014, at 6:27 PM, Craig Rodrigues wrote: > > > >> Warner, > >> > >> It looks like your change broke the FreeBSD-HEAD-modules > >> build. > >> > >> This build does the following: > >> > >> export JFLAG="-j4" > >> export MAKESYSPATH="${WORKSPACE}/mk” > > > > Shouldn’t this be ${WORKSPACE}/share/mk? MAKESYSPATH needs to be …/share/mk or $TOP/share/mk when building outside of make world-like environments now. > > > > Warner > > > >> cd ${WORKSPACE}/sys/modules > >> echo "=== make cleandir ===" > >> make cleandir > >> echo "=== make depend ===" > >> make ${JFLAG} depend > >> echo "=== make all ===" > >> make ${JFLAG} all > > Just confirmed that it works with a proper MAKESYSPATH… > > Warner > This job checks out svn://svn.freebsd.org/base/head/sys to ${WORKSPACE}/sys and svn://svn.freebsd.org/base/head/share/mk to ${WORKSPACE}/mk , then sets MAKESYSPATH="${WORKSPACE}/mk" since I was trying not to check out the whole src tree. Just be curious, why in line 24 of sys/conf/kern.opts.mk , we do: .include "../../share/mk/bsd.mkopt.mk" but not: .include like other .mk files under sys/conf ? I tried to switch to this and it seems work, but I am not sure if this is your original intention. I'll change the modules building job to checkout the whole src tree if this is not an accepted solution. Thanks, Li-Wen -- Li-Wen Hsu http://lwhsu.org