From owner-freebsd-bugs@FreeBSD.ORG  Sat Jan 14 11:59:53 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@FreeBSD.org
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 15F3116A41F;
	Sat, 14 Jan 2006 11:59:53 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BF04C43D45;
	Sat, 14 Jan 2006 11:59:52 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id 3868346BC0;
	Sat, 14 Jan 2006 06:59:50 -0500 (EST)
Date: Sat, 14 Jan 2006 12:00:10 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Gleb Smirnoff <glebius@FreeBSD.org>
In-Reply-To: <200601121407.k0CE7D3Z004195@freefall.freebsd.org>
Message-ID: <20060114115916.L38874@fledge.watson.org>
References: <200601121407.k0CE7D3Z004195@freefall.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: bachue@bachue.com, freebsd-bugs@FreeBSD.org
Subject: Re: kern/31746: failed connect(2) seems to cause problems
	with	socket
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Jan 2006 11:59:53 -0000


On Thu, 12 Jan 2006, Gleb Smirnoff wrote:

> Synopsis: failed connect(2) seems to cause problems with socket
>
> State-Changed-From-To: open->closed
> State-Changed-By: glebius
> State-Changed-When: Thu Jan 12 14:05:59 UTC 2006
> State-Changed-Why:
> This is a POSIX compliant behavior. Quoting
>
> http://www.opengroup.org/onlinepubs/000095399/functions/connect.html
>
> "If connect() fails, the state of the socket is unspecified. Conforming 
> applications should close the file descriptor and create a new socket before 
> attempting to reconnect."

All that said -- I don't like that so_pcb is ending up NULL.  Our socket/pcb 
state machines are somewhat inconsistent, and it will trip us up in the future 
as well.  I'll investigate changing the current behavior, assuming it doesn't 
require too much immediate socket/pcb code surgery.

Robert N M Watson