From owner-svn-ports-all@FreeBSD.ORG  Tue Dec 16 14:24:22 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 3F3A4AF9; Tue, 16 Dec 2014 14:24:22 +0000 (UTC)
Date: Tue, 16 Dec 2014 14:24:22 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Alex Kozlov <ak@FreeBSD.org>
Subject: Re: svn commit: r374800 - head/Mk/Uses
Message-ID: <20141216142422.GA38033@FreeBSD.org>
References: <201412161206.sBGC6fa5045717@svn.freebsd.org>
 <54902709.9090801@marino.st>
 <71EBD6FD6D89266B6651554A@ogg.in.absolight.net>
 <20141216133802.GA27647@ravenloft.kiev.ua>
 <5B209A4BD7689CD74744CFA7@ogg.in.absolight.net>
 <20141216141320.GA28332@ravenloft.kiev.ua>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20141216141320.GA28332@ravenloft.kiev.ua>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: Mathieu Arnold <mat@FreeBSD.org>, svn-ports-head@freebsd.org,
 svn-ports-all@freebsd.org, ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Dec 2014 14:24:22 -0000

On Tue, Dec 16, 2014 at 04:13:20PM +0200, Alex Kozlov wrote:
> On Tue, Dec 16, 2014 at 02:47:09PM +0100, Mathieu Arnold wrote:
> > +--On 16 d'ecembre 2014 15:38:02 +0200 Alex Kozlov <ak@FreeBSD.org> wrote:
> > | Allow me to ask, why it should be 8 and not 4?
> > 
> > Because a tabulation is 8 spaces.  It should be consistent over the whole
> > ports tree.
> 
> Well, 'Please view me with 4 column tabs!' line was added to bsd.port.mk
> more than 20 year ago, in rev 69, because it's inconvenient to view it with
> default tabulation value: many wrapped lines, indentation too deep, etc.

I think I agree with Alex here.  While most of us prefer ts=8, I don't see
the need to reindent some files, most notably b.p.m., as it will completely
jeopardize its history and make 'svn blame' basically useless.

Even with editors that cannot grok ex:ts=X hints, its not that hard to do it
manually every time you need to view/edit these files.  I do it all the time
with nvi(1).

./danfe