From owner-freebsd-toolchain@freebsd.org Fri Nov 3 02:41:46 2017 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 67300E69221; Fri, 3 Nov 2017 02:41:46 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 411577329B; Fri, 3 Nov 2017 02:41:46 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 86D1215FB6; Fri, 3 Nov 2017 02:41:45 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 712E88E48; Fri, 3 Nov 2017 02:41:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id zildTF2mjAJd; Fri, 3 Nov 2017 02:41:41 +0000 (UTC) Content-Type: text/plain; charset=utf-8 DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 252538E45 Mime-Version: 1.0 (1.0) Subject: Re: Head build unsafe for /etc today From: Bryan Drewery X-Mailer: iPhone Mail (15A402) In-Reply-To: <20171103022327.GA88659@troutmask.apl.washington.edu> Date: Thu, 2 Nov 2017 19:41:21 -0700 Cc: FreeBSD Toolchain , freebsd-hackers , FreeBSD Current Content-Transfer-Encoding: quoted-printable Message-Id: <998FF503-D4B0-4AD5-AD55-98680E4D66CA@FreeBSD.org> References: <3045EEBF-09E6-4209-B54F-2F95394DBA82@FreeBSD.org> <20171103014907.GA88522@troutmask.apl.washington.edu> <68BECDA4-C182-436E-854C-C3B19ABB4373@FreeBSD.org> <20171103022327.GA88659@troutmask.apl.washington.edu> To: sgk@troutmask.apl.washington.edu X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 02:41:46 -0000 > On Nov 2, 2017, at 19:23, Steve Kargl w= rote: >=20 >> On Thu, Nov 02, 2017 at 07:08:50PM -0700, Bryan Drewery wrote: >>=20 >>=20 >>>> On Nov 2, 2017, at 18:49, Steve Kargl wrote: >>>>=20 >>>> On Thu, Nov 02, 2017 at 06:25:24PM -0700, Bryan Drewery wrote: >>>>=20 >>>> On Nov 2, 2017, at 15:44, Mark Millard wrote: >>>>=20 >>>>>> Author: bdrewery >>>>>> Date: Thu Nov 2 22:23:00 2017 >>>>>> New Revision: 325347 >>>>>> URL:=20 >>>>>> https://svnweb.freebsd.org/changeset/base/325347 >>>>>>=20 >>>>>>=20 >>>>>> Log: >>>>>> Something is very wrong >>>>=20 >>>>=20 >>>> Unfortunately I only test with META_MODE these days which implies -DNO_= CLEAN. >>>=20 >>> You're making changes to the build infrastructure and you're >>> not properly testing it before committing? This is beyond >>> pointyhat material.=20 >>=20 >> I ran 2 universes, dozens of buildworlds and buildkernels, dozens of inst= allworld and installkernel, several xdev and native-xtools, several full DIR= DEPS_BUILD builds and bootstraps, ran subdir builds, ran subdir cleans, test= ed several targets together, ran various special case tests for submakes, pl= ayed around with a ton of MAKEOBJDIRPREFIX cases, handled and tested symlink= ed objdirs special, ran it through my work repro a few times, did special te= sting in rescue/, and had a volunteer test release. In the process I found= a bmake bug, GPL_DTC build bug and several others I don=E2=80=99t recall fr= om the bus. >>=20 >> What I missed was the =E2=80=9Cclean=E2=80=9D buildworld because I forgot= it even exists. I=E2=80=99ve wanted to remove it for a year. I also forgot t= o test buildenv. >>=20 >=20 > If you did all the above under META_MODE, then no you did not=20 > buildworld and buildkernel and all the other stuff you claim. Are you accusing me of lying? > If your first step isn't 'cd /usr/obj ; rm -rf *' or equivalent > in whatever jail you use, then you're not properly testing=20 > your changes to the build I did that probably 100 times. And that isn=E2=80=99t even =E2=80=9Cthe prop= er test=E2=80=9D. Both clean and incremental are needed which I did. zfs sna= pshots help a lot there. I just never ran =E2=80=9C_cleanobj=E2=80=9D which d= oes a full tree walk of clean. But I ran make clean in some subdirs many tim= es. > infrastructure. As you have demonstrated, > Makefile, Makefile.inc1, and the *.mk files are sufficiently=20 > complicated that proper testing > should be done, and proper=20 > testing means one doesn't takes shortcuts. I took 0 shortcuts. As I said I *forgot* that case, among hundreds of cases.= You=E2=80=99re welcome to do this work if you want. I guarantee you would no= t have tested even half of what I tested.=20 Hey can you fix universe to only build clang once please? I=E2=80=99ve been w= orking up to that but I think you=E2=80=99re best to do it. >=20 > --=20 > Steve