From owner-svn-src-head@FreeBSD.ORG  Fri Dec  3 21:56:30 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8F356106566C;
	Fri,  3 Dec 2010 21:56:30 +0000 (UTC)
	(envelope-from mdf356@gmail.com)
Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com
	[209.85.214.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 364AF8FC0C;
	Fri,  3 Dec 2010 21:56:29 +0000 (UTC)
Received: by iwn39 with SMTP id 39so11660793iwn.13
	for <multiple recipients>; Fri, 03 Dec 2010 13:56:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:sender:received
	:in-reply-to:references:date:x-google-sender-auth:message-id:subject
	:from:to:cc:content-type:content-transfer-encoding;
	bh=NcNOkCzyd67B8PChdPXOZuBdj6vGQDwtJL74J1NYo90=;
	b=AQD+rEDoYPfrZRNV+uM7mRsl2hLlFqx5KTHtLy6rWvcpYF8limLRtfVSCwyy4YFl9t
	JDfKlr6CK8XKXKsfil2vfG4XpIQtqg3laXrBCQnyeYasw7fil+kBpz8p0tWntsEhEA4S
	4Cxn7fFHF6cklw+c1bjOwRFl5NxSNbFO6L/yA=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type
	:content-transfer-encoding;
	b=eIDgY+KBPRXRJy9Mh1OmKkbwNsIDVMGmeDL7EPTZB0TwqY6bsoCdmE2Ht0tFS62vch
	Tx939lH55OC5AN+5njX8xLNzJ99uU5fJDnDaK3qi0Zc9DOUwc4BJ1WpstDnLgT+9zdHP
	q4iDNbmGav1mEKRD0uWS/QJYNFmSQszIArpBU=
MIME-Version: 1.0
Received: by 10.231.11.9 with SMTP id r9mr2433582ibr.47.1291413389372; Fri, 03
	Dec 2010 13:56:29 -0800 (PST)
Sender: mdf356@gmail.com
Received: by 10.231.21.35 with HTTP; Fri, 3 Dec 2010 13:56:29 -0800 (PST)
In-Reply-To: <201012032154.oB3LsADC035461@svn.freebsd.org>
References: <201012032154.oB3LsADC035461@svn.freebsd.org>
Date: Fri, 3 Dec 2010 13:56:29 -0800
X-Google-Sender-Auth: S6YIM_27mmK5EIAgBm0RgP9YnfM
Message-ID: <AANLkTi=mFhQQd8+seT4mi7yPw+z9tunpMd4rVrUoyO7x@mail.gmail.com>
From: mdf@FreeBSD.org
To: Jung-uk Kim <jkim@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r216161 - in head/sys: amd64/amd64 i386/i386
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Dec 2010 21:56:30 -0000

On Fri, Dec 3, 2010 at 1:54 PM, Jung-uk Kim <jkim@freebsd.org> wrote:
> Author: jkim
> Date: Fri Dec =A03 21:54:10 2010
> New Revision: 216161
> URL: http://svn.freebsd.org/changeset/base/216161
>
> Log:
> =A0Explicitly initialize TSC frequency. =A0To calibrate TSC frequency, we=
 use
> =A0DELAY(9) and it may use TSC in turn if TSC frequency is non-zero.

Doesn't ELF guarantee that the static data is already 0?  On AIX the
kernel had to explicitly zero the non-initialized data area, but AIX
uses the a.out format.  I thought FreeBSD/ELF meant that global
variables without initializers were 0 by the time the OS started
running.

Thanks,
matthew

>
> =A0MFC after: =A0 =A03 days
>
> Modified:
> =A0head/sys/amd64/amd64/tsc.c
> =A0head/sys/i386/i386/tsc.c
>
> Modified: head/sys/amd64/amd64/tsc.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/amd64/amd64/tsc.c =A0Fri Dec =A03 21:52:01 2010 =A0 =A0 =A0 =
=A0(r216160)
> +++ head/sys/amd64/amd64/tsc.c =A0Fri Dec =A03 21:54:10 2010 =A0 =A0 =A0 =
=A0(r216161)
> @@ -46,7 +46,7 @@ __FBSDID("$FreeBSD$");
>
> =A0#include "cpufreq_if.h"
>
> -uint64_t =A0 =A0 =A0 tsc_freq;
> +uint64_t =A0 =A0 =A0 tsc_freq =3D 0;
> =A0int =A0 =A0 =A0 =A0 =A0 =A0tsc_is_broken;
> =A0int =A0 =A0 =A0 =A0 =A0 =A0tsc_is_invariant;
> =A0static eventhandler_tag tsc_levels_tag, tsc_pre_tag, tsc_post_tag;
>
> Modified: head/sys/i386/i386/tsc.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/i386/i386/tsc.c =A0 =A0Fri Dec =A03 21:52:01 2010 =A0 =A0 =
=A0 =A0(r216160)
> +++ head/sys/i386/i386/tsc.c =A0 =A0Fri Dec =A03 21:54:10 2010 =A0 =A0 =
=A0 =A0(r216161)
> @@ -46,7 +46,7 @@ __FBSDID("$FreeBSD$");
>
> =A0#include "cpufreq_if.h"
>
> -uint64_t =A0 =A0 =A0 tsc_freq;
> +uint64_t =A0 =A0 =A0 tsc_freq =3D 0;
> =A0int =A0 =A0 =A0 =A0 =A0 =A0tsc_is_broken;
> =A0int =A0 =A0 =A0 =A0 =A0 =A0tsc_is_invariant;
> =A0u_int =A0 =A0 =A0 =A0 =A0tsc_present;
>