Date: Wed, 21 Jan 2009 23:19:05 +0100 From: Herve Quiroz <hq@FreeBSD.org> To: andy.lavr@gmail.com Cc: java@FreeBSD.org Subject: Re: New patch ant.sh.in for FreeBSD ports devel/apache-ant Message-ID: <49779F59.6050209@FreeBSD.org> In-Reply-To: <49749D98.4080402@reactor-xg.kiev.ua> References: <49749D98.4080402@reactor-xg.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Andrei,
Well, the good side is that I don't think this patch will break anything
in the ports tree. OTOH I think you were right in the first place.
Looking at the original shell script for the distribution, the correct
argument is ${ANT_LIB}. The problem is that there are some Java
libraries in the ports tree that are installing custom tasks as JAR
files in ${JAVAJARDIR} and these will no longer be available as-is from
Ant.
I am still unsure if we should go for upstream-behavior correctness or
ports behavior stability.
So far I know about the following ports that provide an Ant task in the
JAR file installed in JAVAJARDIR:
- java/java-checkstyle
- textproc/ant-xinclude-task
Main problem here is that we can't build all Java ports and analyze the
content of the JAR files. And using portsearch, I could just list the
following ports with a run dependency on devel/apache-ant:
- java/xdoclet (JAR contains an Ant task)
- www/extsm
- www/jetspeed
Maybe we could just assume that ports that do not correctly reference
their run dependencies are more likely to be broken anyway.
BTW, the best way to set this option is through -Dant.library.dir.
I'll do more tests with the patch applied and see if any "critical" port
fails to build.
Herve
Andrei V. Lavreniyuk wrote:
> Hi!
>
>
>
> It will be more correct whew, view attached files - patch-ant.sh.in
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49779F59.6050209>