Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 2 Dec 2010 15:42:36 -0500
From:      Eitan Adler <lists@eitanadler.com>
To:        freebsd ports <freebsd-ports@freebsd.org>
Subject:   Re: updated dialog(1) replacement for ports
Message-ID:  <AANLkTimS4TuDh9K9seqWQ8nTEUCwh7FEu=pDn5%2B_mCyK@mail.gmail.com>
In-Reply-To: <20101202175833.GG83341@libertas.local.camdensoftware.com>
References:  <AANLkTim--0fKfdZqRNeWAwAWfNATjhnFOh5gZGx-0_qT@mail.gmail.com> <20101202160617.GD83341@libertas.local.camdensoftware.com> <AANLkTin%2BrnWa02PEZ9YOuiX_84oOnvZvPaPnPE44TY-=@mail.gmail.com> <20101202175833.GG83341@libertas.local.camdensoftware.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 2, 2010 at 12:58 PM, Chip Camden
<sterling@camdensoftware.com> wrote:
> Quoth Eitan Adler on Thursday, 02 December 2010:
>> Thank you for your comments
>>
>> > Every keystroke causes the screen to completely repaint.
>> This can't be fully helped. Any valid key stroke is going to cause
>> this. However I did make invalid keystrokes skip the repainting.
>
> Ugh -- I haven't looked at the code yet, but even back in the curses days
> (pre-ncurses) this problem had already been solved.

The window layout looks like
|              Title       |
|  primary  |  help  |
|            license     |
|            exit          |

And on every valid keystroke primary and help need to be refreshed.
ncurses is optimized to handle this correctly.
However the wborder command on "primary" and "help" for some reason
touches "title" and "license" as well - so the doupdate() ncurses
functions refreshes them as well.

If you could find a way to solve the problem please let know - a patch
would be better :-)

>Heh -- sorry, I always begin my tests in "stupid user" mode.  Thanks for
> the patch!

No problem - segfaults should be fixed :-)


Again - thanks for your comments: I'd like to get this program into
tip-top shape so when I get the bsd.port.mk patch I'll just submit a
PR and wait for the flames :-)
-- 
Eitan Adler



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTimS4TuDh9K9seqWQ8nTEUCwh7FEu=pDn5%2B_mCyK>