Date: Thu, 13 Feb 2025 18:50:33 +0000 From: Nuno Teixeira <eduardo@freebsd.org> To: Zsolt Udvari <uzsolt@freebsd.org> Cc: freebsd-ports@freebsd.org Subject: Re: cran.mk strange do-test Message-ID: <CAFDf7UKLEG4JTJNpt2FftYc0Rv2H=p-8oiJVJPa5S6_ACSzMeA@mail.gmail.com> In-Reply-To: <Z64chbwLJTsUyXYT@bsd-zsolt> References: <Z6kAEmeaAh7jtMMW@bsd-zsolt> <Z64chbwLJTsUyXYT@bsd-zsolt>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000000e7035062e0a8911 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, Just tested OK: +MAKE_ENV+=3D LC_ALL=3DC.UTF-8 As you are suspecting that LC_ALL is affecting tests, you can now test with other values. If you can "prove" that it fails on a certain vallue, then upstream should fix tests to work on all values or force it to specific one. Cheers Zsolt Udvari <uzsolt@freebsd.org> escreveu (quinta, 13/02/2025 =C3=A0(s) 16= :24): > Found the difference: in the clean poudriere jail the LC_ALL variable is > empty but in the ports 'make test' the LC_ALL is C. > > If I set the LC_ALL to C the 'R CMD check' fails too. > > Could you please check it who use R? Any ideas? > > Cheers, > Zsolt > > On Sun, Feb 09, 2025 at 08:20:50PM +0100, Zsolt Udvari wrote: > > Hi all, > > > > I run a strange issue in Mk/Uses/cran.mk, and I don't understand. > > > > I updated devel/R-cran/sessioninfo > (2cfb7dfba861db7f6216f8aaa5fa81f1148c12f1). > > The 'make test' fails so I opened an issue on project page [1]. > > The developer show me that the 'R CMD check' runs well. I checked it in > > poudriere jail - yes, he's right. So it seems it is an ports > > framework-specific issue. > > > > I begin play with Mk/Uses/cran.mk. > > If I copy and run the full command [2] works fine so IMHO the command i= s > okay. > > I copied it into /root/test.sh. Running of /root/test.sh is okay, > > all tests passed (or skipped). > > I changed the command in cran.mk to '/bin/sh /root/test.sh' - the test > fails > > (as in github issue)! > > > > Do you have any idea why fails with ports framework and how can fix it? > > > > Thanks, > > Zsolt > > > > [1] https://github.com/r-lib/sessioninfo/issues/111 > > [2] https://cgit.freebsd.org/ports/tree/Mk/Uses/cran.mk#n39 > > > > --=20 Nuno Teixeira FreeBSD UNIX: <eduardo@FreeBSD.org> Web: https://FreeBSD.org --0000000000000e7035062e0a8911 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>Hello,</div><div><br></div><div>Just tested OK:</div>= <div><br></div><div>+MAKE_ENV+=3D =C2=A0 =C2=A0 =C2=A0 LC_ALL=3DC.UTF-8</di= v><div><br></div><div>As you are suspecting that LC_ALL is affecting tests,= you can now test with other values.<br></div><div>If you can "prove&q= uot; that it fails on a certain vallue, then upstream should fix tests to w= ork on all values or force it to specific one.</div><div><br></div><div>Che= ers</div></div><br><div class=3D"gmail_quote gmail_quote_container"><div di= r=3D"ltr" class=3D"gmail_attr">Zsolt Udvari <<a href=3D"mailto:uzsolt@fr= eebsd.org">uzsolt@freebsd.org</a>> escreveu (quinta, 13/02/2025 =C3=A0(s= ) 16:24):<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0p= x 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Found = the difference: in the clean poudriere jail the LC_ALL variable is<br> empty but in the ports 'make test' the LC_ALL is C.<br> <br> If I set the LC_ALL to C the 'R CMD check' fails too.<br> <br> Could you please check it who use R? Any ideas?<br> <br> Cheers,<br> =C2=A0 Zsolt<br> <br> On Sun, Feb 09, 2025 at 08:20:50PM +0100, Zsolt Udvari wrote:<br> > Hi all,<br> > <br> > I run a strange issue in Mk/Uses/<a href=3D"http://cran.mk" rel=3D"nor= eferrer" target=3D"_blank">cran.mk</a>, and I don't understand.<br> > <br> > I updated devel/R-cran/sessioninfo (2cfb7dfba861db7f6216f8aaa5fa81f114= 8c12f1).<br> > The 'make test' fails so I opened an issue on project page [1]= .<br> > The developer show me that the 'R CMD check' runs well. I chec= ked it in<br> > poudriere jail - yes, he's right. So it seems it is an ports<br> > framework-specific issue.<br> > <br> > I begin play with Mk/Uses/<a href=3D"http://cran.mk" rel=3D"noreferrer= " target=3D"_blank">cran.mk</a>.<br> > If I copy and run the full command [2] works fine so IMHO the command = is okay.<br> > I copied it into /root/test.sh. Running of /root/test.sh is okay,<br> > all tests passed (or skipped).<br> > I changed the command in <a href=3D"http://cran.mk" rel=3D"noreferrer"= target=3D"_blank">cran.mk</a> to '/bin/sh /root/test.sh' - the tes= t fails<br> > (as in github issue)!<br> > <br> > Do you have any idea why fails with ports framework and how can fix it= ?<br> > <br> > Thanks,<br> >=C2=A0 =C2=A0Zsolt<br> > <br> > [1] <a href=3D"https://github.com/r-lib/sessioninfo/issues/111" rel=3D= "noreferrer" target=3D"_blank">https://github.com/r-lib/sessioninfo/issues/= 111</a><br> > [2] <a href=3D"https://cgit.freebsd.org/ports/tree/Mk/Uses/cran.mk#n39= " rel=3D"noreferrer" target=3D"_blank">https://cgit.freebsd.org/ports/tree/= Mk/Uses/cran.mk#n39</a><br> > <br> <br> </blockquote></div><div><br clear=3D"all"></div><br><span class=3D"gmail_si= gnature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><d= iv dir=3D"ltr"><div><font color=3D"#888888">Nuno Teixeira</font></div><div>= <div><font color=3D"#888888"> FreeBSD UNIX:=C2=A0 <eduardo@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 <a h= ref=3D"https://FreeBSD.org" rel=3D"noreferrer" target=3D"_blank">https://Fr= eeBSD.org</a><br></font></div></div></div></div> --0000000000000e7035062e0a8911--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UKLEG4JTJNpt2FftYc0Rv2H=p-8oiJVJPa5S6_ACSzMeA>