Date: Wed, 1 Mar 2017 12:16:27 +0000 From: =?UTF-8?Q?Bart=C5=82omiej_Rutkowski?= <robak@freebsd.org> To: Kristof Provost <kp@freebsd.org> Cc: =?UTF-8?Q?Bart=C5=82omiej_Rutkowski?= <robak@freebsd.org>, Warner Losh <imp@bsdimp.com>, git@freebsd.org Subject: Re: pull requests Message-ID: <CAGFrfxYSKPoLZQ34n%2B%2Bzo6ODNoY52=x-sm%2BDZKMJ85egM8_UFw@mail.gmail.com> In-Reply-To: <5D8FF3CD-422C-489A-B009-454CA1031E5E@FreeBSD.org> References: <CANCZdfoT%2B9nHqS2qYuf_-sBAYDAzH=2ePW=ADPwGhjUG00S2Jw@mail.gmail.com> <CAGFrfxZRUWryg8nHQ2gGbrcZ1U1EgsaSVfpn_mgortmih99fAQ@mail.gmail.com> <C6BF03E7-64B8-4183-9095-76C5757FAF3C@FreeBSD.org> <CAGFrfxa3LPY6VM0wbfCbvaOinKHGOCVCBEjbrLBMoFumNWg3zA@mail.gmail.com> <5D8FF3CD-422C-489A-B009-454CA1031E5E@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 1, 2017 at 12:07 PM, Kristof Provost <kp@freebsd.org> wrote: > On 1 Mar 2017, at 13:00, Bart=C5=82omiej Rutkowski wrote: > >> Don't get me wrong, I am simply trying to understand what exactly would >> that accomplish - see https://reviews.freebsd.org/D9649. Lets, for a fun >> thought experiment, imagine it was an GH pull request that was transferr= ed >> to Phabric. What now? 2 weeks passed and nothing happened. Would any >> policy >> fix that? >> >> No, the best policy in the world isn=E2=80=99t going to fix lack of time= . > > It might help a little if these at least all land on the same pile, but > it=E2=80=99s > not going to magic up reviewers. I=E2=80=99m not sure anything would. > > A possibly policy answer would be that reviews are automatically closed > after a > while. It=E2=80=99s not great, but at least the submitter knows that noth= ing is > going > to happen. Leaving it open forever also accomplishes nothing. > Well, have you seen Bugzilla recently, or ever? :) We've THOUSANDS open PR's (literally, ~2300 for ports, ~6800 for src, with oldest ones going back as far as to 2001). Does it make any sense to waste time to write such policies for Phabric but not for Bugzilla? And if you're about to write one for both, good luck convincing people that bugs shouldn't just lay around forever 'just in case'... In any case, if you'd happen to me successful with that, I'd support it. While 'just in case' argument makes some sense, I still think that keeping more PR's open than we can really handle causes cognitive load and discouragement in taking care of them just by sheer looking at the number of PR's. Kind regards, Bartek Rutkowski
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGFrfxYSKPoLZQ34n%2B%2Bzo6ODNoY52=x-sm%2BDZKMJ85egM8_UFw>