Date: Tue, 26 Aug 2014 11:09:23 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Tom Jones <jones@sdf.org> Cc: FreeBSD Net <freebsd-net@freebsd.org>, "Eggert, Lars" <lars@netapp.com> Subject: Re: Patches for RFC6937 and draft-ietf-tcpm-newcwv-00 Message-ID: <CAJ-Vmo=TsqAKUrV3BRAk1bX9E1zKq7j5og5CHv4PEz-9sqXpAA@mail.gmail.com> In-Reply-To: <20140826145517.GD12732@gmail.com> References: <259C9434-C6FE-42EA-823D-ECB024DBF3D7@netapp.com> <B7145157-9A03-4053-BFCC-627633E20122@neville-neil.com> <814E0886-1B6B-4316-8BAB-684DAFDE1983@netapp.com> <20140826145517.GD12732@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi! I'm going to merge Tom's work in a week unless someone gives me a really good reason not to. I think there's been enough work and discussion about it since the first post from Lars in Feburary and enough review opportunity. -a On 26 August 2014 07:55, Tom Jones <jones@sdf.org> wrote: > On Tue, Aug 26, 2014 at 02:43:49PM +0000, Eggert, Lars wrote: >> Hi, >> >> the newcwv patch is probably stale now with Tom Jones' recent patch base= d on >> a more up-to-date version of the Internet-Draft, but the PRR patch shoul= d >> still be useful? > > My newcwv patch is much more up to date than Aris's, but it is slightly > different in implementation. I have had a few suggestions from Adrian, bu= t he > couldn't comment on how it relates to the tcp internals. > > There is a PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D191520 > > The biggest difference in structure between mine and Aris's patch is the = use of > tcp timers. It would be good to hear if my approach or Aris's is prefered= . > >> On 2014-6-19, at 23:35, George Neville-Neil <gnn@neville-neil.com> wrote= : >> >> > On 4 Feb 2014, at 1:38, Eggert, Lars wrote: >> > >> >> Hi, >> >> >> >> below are two patches that implement RFC6937 ("Proportional Rate Redu= ction for TCP") and draft-ietf-tcpm-newcwv-00 ("Updating TCP to support Rat= e-Limited Traffic"). They were done by Aris Angelogiannopoulos for his MS t= hesis, which is at https://eggert.org/students/angelogiannopoulos-thesis.pd= f. >> >> >> >> The patches should apply to -CURRENT as of Sep 17, 2013. (Sorry for t= he delay in sending them, we'd been trying to get some feedback from commit= ters first, without luck.) >> >> >> >> Please note that newcwv is still a work in progress in the IETF, and = the patch has some limitations with regards to the "pipeACK Sampling Period= " mentioned in the Internet-Draft. Aris says this in his thesis about what = exactly he implemented: >> >> >> >> "The second implementation choice, is in regards with the measurement= of pipeACK. This variable is the most important introduced by the method a= nd is used to compute the phase that the sender currently lies in. In order= to compute pipeACK the approach suggested by the Internet Draft (ID) is fo= llowed [ncwv]. During initialization, pipeACK is set to the maximum possibl= e value. A helper variable prevHighACK is introduced that is initialized to= the initial sequence number (iss). prevHighACK holds the value of the high= est acknowledged byte so far. pipeACK is measured once per RTT meaning that= when an ACK covering prevHighACK is received, pipeACK becomes the differen= ce between the current ACK and prevHighACK. This is called a pipeACK sample= . A newer version of the draft suggests that multiple pipeACK samples can = be used during the pipeACK sampling period." >> >> >> >> Lars >> >> >> >> >> >> [prr.patch] >> >> >> >> [newcwv.patch] >> > >> > Apologies for not looking at this as yet. It is now closer to the top= of my list. >> > >> > Best, >> > George >> > > > > -- > Tom > @adventureloop > adventurist.me > > :wq > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmo=TsqAKUrV3BRAk1bX9E1zKq7j5og5CHv4PEz-9sqXpAA>