Date: Tue, 30 Jan 2001 11:29:31 +0600 (ALMT) From: Boris Popov <bp@freebsd.org> To: Bosko Milekic <bmilekic@technokratis.com> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_malloc.c src/sys/sys malloc.h Message-ID: <Pine.BSF.4.21.0101301113150.47663-100000@lion.butya.kz> In-Reply-To: <000901c08a73$c9b37f70$1f90c918@jehovah>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 29 Jan 2001, Bosko Milekic wrote: > In this case, don't you agree that using malloc() with M_WAITOK > would be more appropriate? In the broken state that it is, > kmem_malloc() will panic if it can't find the address space in > kmem_map _anyway_, as long as you're calling with M_WAITOK. Adding > M_PANIC is redundant in this light. Dunno, the line 189 in kern_malloc.c (rev 1.80) tells that the return value can be NULL even with M_WAITOK. If this is not true then this change is obviously wrong. -- Boris Popov http://www.butya.kz/~bp/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0101301113150.47663-100000>