Date: Mon, 11 Jun 2001 21:01:25 +0300 From: Ruslan Ermilov <ru@freeBSD.org> To: Paul Marquis <pmarquis@pobox.com> Cc: freebsd-bugs@freeBSD.org Subject: Re: misc/28035: make buildworld fails on 4.2-RELEASE -> RELENG_4 Message-ID: <20010611210125.A27882@sunbay.com> In-Reply-To: <01061113252003.00418@sboy.pmarquis.com>; from pmarquis@pobox.com on Mon, Jun 11, 2001 at 01:55:14PM -0400 References: <200106111616.f5BGGs781480@freefall.freebsd.org> <01061113252003.00418@sboy.pmarquis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is definitely a bug on your side. Are you sure you're
doing a `make buildworld' and not `make all'?
`buildworld' stage of Makefile.inc1 installs new headers into
${WORLDTMP}/usr/include directory, which is usually points to
/usr/obj/usr/src/i386/usr/include. Then, all is built with
DESTDIR=${WORLDTMP} which causes bsd.prog.mk and bsd.lib.mk
to add CFLAGS+=-I${DESTDIR}/usr/include, so you should see
the -I/usr/obj/usr/src/i386/usr/include line in the `buildworld'
output. Note the missing -I in your output after a -DNO_IDEA.
Here is the correct output you should see:
cc -nostdinc -O -pipe -I/usr/src/secure/lib/libcrypt/../../../lib/libmd -I/usr/src/secure/lib/libcrypt/../../../lib/libcrypt -DHAS_BLOWFISH -DHAS_DES -DLIBC_SCCS -Wall -DMD5Init=__MD5Init -DMD5Final=__MD5Final -DMD5Update=__MD5Update -DMD5Pad=__MD5Pad -Dauth_getval=__auth_getval -Dproperty_find=__property_find -Dproperties_read=__properties_read -Dproperties_free=__properties_free -DNO_IDEA -I/usr/obj/usr/src/i386/usr/include -c /usr/src/secure/lib/libcrypt/../../../lib/libcrypt/crypt.c -o crypt.o
On Mon, Jun 11, 2001 at 01:55:14PM -0400, Paul Marquis wrote:
> They may get installed properly during a buildworld (or should that
> be installworld), but without my patch, the libcrypt library gets
> built against some headers in /usr/include, specifically libutil.h,
> and can't even be built!
>
> Between 4.2-RELEASE and 4.3-RELEASE, the following log entry appears
> for libutil.h:
>
> 1.29 - Added PROPERTY_MAX_VALUE and PROPERTY_MAX_NAME
> defines to libutil.h so that applications know how large
> of a buffer they must allocate before calling
> property_find(). Also added a $FreeBSD$ tag while I'm here.
>
> Thus, in 4.2-RELEASE, PROPERTY_MAX_VALUE and PROPERTY_MAX_NAME are
> not defined in /usr/include/libutil.h.
>
> After upgrading my sources to STABLE, when I do a make buildworld
> without my patch, the compiler uses libutil.h from /usr/include for
> the files built in lib/libcrypt. Some of those files use the above
> macros, and since they're not defined in libutil.h from /usr/include,
> the following errors occur:
>
> cc -O -pipe -I/usr/src/secure/lib/libcrypt/../../../lib/libmd
> -I/usr/src/secure/lib/libcrypt/../../../lib/libcrypt -DHAS_BLOWFISH
> -DHAS_DES -DLIBC_SCCS -Wall -DMD5Init=__MD5Init -DMD5Final=__MD5Final
> -DMD5Update=__MD5Update -DMD5Pad=__MD5Pad -Dauth_getval=__auth_getval
> -Dproperty_find=__property_find -Dproperties_read=__properties_read
> -Dproperties_free=__properties_free -DNO_IDEA -c
> /usr/src/secure/lib/libcrypt/../../../lib/libutil/property.c -o
> property.o
> /usr/src/secure/lib/libcrypt/../../../lib/libutil/property.c: In
> function `__properties_read':
> /usr/src/secure/lib/libcrypt/../../../lib/libutil/property.c:60:
> `PROPERTY_MAX_NAME' undeclared (first use in this function)
> /usr/src/secure/lib/libcrypt/../../../lib/libutil/property.c:60:
> (Each undeclared identifier is reported only once
> /usr/src/secure/lib/libcrypt/../../../lib/libutil/property.c:60:
> for each function it appears in.)
> /usr/src/secure/lib/libcrypt/../../../lib/libutil/property.c:60: size
> of array `hold_n' has non-integer type
> /usr/src/secure/lib/libcrypt/../../../lib/libutil/property.c:61:
> `PROPERTY_MAX_VALUE' undeclared (first use in this function)
> /usr/src/secure/lib/libcrypt/../../../lib/libutil/property.c:61: size
> of array `hold_v' has non-integer type:
>
> This is definitely a bug. Please don't just close it.
>
> On Monday 11 June 2001 12:16, ru@FreeBSD.org wrote:
> > Synopsis: make buildworld fails on 4.2-RELEASE -> RELENG_4
> >
> > State-Changed-From-To: open->closed
> > State-Changed-By: ru
> > State-Changed-When: Mon Jun 11 09:15:27 PDT 2001
> > State-Changed-Why:
> > Proper set of header files is installed during `buildworld'
> > into ${WORLDTMP} (/usr/obj/usr/src/i386/usr/include).
> >
> > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=28035
>
> --
> Paul Marquis
> pmarqus@pobox.com
--
Ruslan Ermilov Oracle Developer/DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010611210125.A27882>