Date: Tue, 28 Aug 2001 18:18:34 -0700 From: Mark Peek <mark@whistle.com> To: "Steven Ames" <steve@virtual-voodoo.com> Cc: "Jim Bryant" <kc5vdj@yahoo.com>, <FreeBSD-hackers@FreeBSD.ORG> Subject: Re: TCSH bug... Message-ID: <p0510030cb7b1eff3a608@[207.76.207.129]> In-Reply-To: <011401c12fe8$bc76b960$28d90c42@eservoffice.com> References: <3B8AC157.5000203@yahoo.com> <020701c12f43$8e0e2310$28d90c42@eservoffice.com> <3B8AC8DB.5090603@yahoo.com> <004801c12f49$66cccb20$28d90c42@eservoffice.com> <20010827201407.A32152@virtual-voodoo.com> <3B8B05AF.9070004@yahoo.com> <20010827200243.A8113@dragon.nuxi.com> <20010828092016.B21396@virtual-voodoo.com> <20010828100251.A97741@dragon.nuxi.com> <00e201c12fe5$e3daad20$28d90c42@eservoffice.com> <20010828104039.G97741@dragon.nuxi.com> <011401c12fe8$bc76b960$28d90c42@eservoffice.com>
next in thread | previous in thread | raw e-mail | index | archive | help
At 12:41 PM -0500 8/28/01, Steven Ames wrote:
>From: "David O'Brien" <obrien@FreeBSD.ORG>
>> > I'll submit a PR for it if you believe thats appropriate.
>>
>> I am afraid, this would just cause people to forget about the problem
>> rather than to continue pursuing the problem.
>
>Looks like Mark Peek found the problem and already submitted the
>solution to the tcsh folks. Very nice!
Just to follow up, Christos debugged the problem further on one of my test systems and he came up with this official patch. Since this file is on a vendor branch, I have a query to wiser committers to see how to apply this patch.
Mark
-----
Index: tc.func.c
===================================================================
RCS file: /src/pub/tcsh/tc.func.c,v
retrieving revision 3.96
retrieving revision 3.97
diff -u -u -r3.96 -r3.97
--- tc.func.c 2001/08/06 23:52:04 3.96
+++ tc.func.c 2001/08/28 23:13:44 3.97
@@ -1,4 +1,4 @@
-/* $Header: /src/pub/tcsh/tc.func.c,v 3.96 2001/08/06 23:52:04 christos Exp $ */
+/* $Header: /src/pub/tcsh/tc.func.c,v 3.97 2001/08/28 23:13:44 christos Exp $ */
/*
* tc.func.c: New tcsh builtins.
*/
@@ -36,7 +36,7 @@
*/
#include "sh.h"
-RCSID("$Id: tc.func.c,v 3.96 2001/08/06 23:52:04 christos Exp $")
+RCSID("$Id: tc.func.c,v 3.97 2001/08/28 23:13:44 christos Exp $")
#include "ed.h"
#include "ed.defns.h" /* for the function names */
@@ -1296,8 +1296,11 @@
tmp->next->prev = tmp->prev;
xfree((ptr_t) tmp->word);
del = tmp;
+ tmp = tmp->next;
xfree((ptr_t) del);
}
+ we = tmp;
+ continue;
}
}
}
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p0510030cb7b1eff3a608>