Date: Tue, 15 Dec 2015 13:29:41 -0800 From: Warner Losh <imp@bsdimp.com> To: NGie Cooper <yaneurabeya@gmail.com> Cc: "Andrey V. Elsukov" <ae@freebsd.org>, Mariusz Zaborski <oshogbo@freebsd.org>, FreeBSD-Stable ML <freebsd-stable@freebsd.org>, Warner Losh <imp@freebsd.org> Subject: Re: make tinderbox broken with LINT-NOINET on ref10-amd64.freebsd.org (if_gif compilation issues) Message-ID: <CANCZdfoYNNtXMJ68FQwZviMnoEu85q4Koou0Dpk-96xkNyyGKw@mail.gmail.com> In-Reply-To: <04FF06C6-4A84-436E-B9A7-5DDA2E7DFA48@gmail.com> References: <CE7F6687-9D20-4804-896B-6F2AF39AECE7@gmail.com> <20151214165111.GA70582@jarvis.whl> <566EF46A.8080704@FreeBSD.org> <20151214165858.GA76268@jarvis.whl> <566FF870.7030106@FreeBSD.org> <04FF06C6-4A84-436E-B9A7-5DDA2E7DFA48@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 15, 2015 at 11:48 AM, NGie Cooper <yaneurabeya@gmail.com> wrote=
:
>
> > On Dec 15, 2015, at 03:24, Andrey V. Elsukov <ae@FreeBSD.org> wrote:
> >
> > On 14.12.15 19:58, Mariusz Zaborski wrote:
> >> On Mon, Dec 14, 2015 at 07:55:06PM +0300, Andrey V. Elsukov wrote:
> >>> On 14.12.15 19:51, Mariusz Zaborski wrote:
> >>>> On Mon, Dec 14, 2015 at 06:31:52AM -0800, NGie Cooper wrote:
> >>>>> Hi Andrey, Just a heads up that LINT-NOINET seems to be broken on
> >>>>> amd64/i386 with if_gif(4) on stable/10. Could you please fix this?
> >>>>> Thanks, -NGie
> >>>> Hi,
> >>>>
> >>>> I already found the problem we need to MFC r276224 and r277130.
> >>>
> >>> I don't think r277130 is related to this problem.
> >>> I have this patch and I'm trying to build with them.
> >> Not with this but after fixing r276224 it will crash in other place
> which
> >> r277130 is fixing. :)
> >
> > Actually, I don't think that my patch will work correctly.
> > opt_inet.h can contain several options in addition to INET. In such cas=
e
> > the expression
> >
> > OPT_INET!=3D cat ${KERNBUILDDIR}/opt_inet.h; echo
> > .if empty(OPT_INET)
> >
> > will always be true. Are you sure merging of r276224 it works as
> expected?
> >
> > Probably, this patch will work correctly:
>
> Would it be a good idea to do:
>
> MK_INET_SUPPORT?=3Dno
>
> instead of:
>
> MK_INET_SUPPORT=3Dno
>
> , in the event that someone wanted if_gif support but hadn=E2=80=99t conf=
igured
> their kernel yet?
>
No. If your kernel doesn't have INET support, but the if_gif module
does, then it won't load.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoYNNtXMJ68FQwZviMnoEu85q4Koou0Dpk-96xkNyyGKw>