Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 31 Jan 2003 14:17:47 +0100
From:      "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
To:        Akifyev Sergey <asa@gascom.ru>
Cc:        FreeBSD-gnats-submit@FreeBSD.org, ports@FreeBSD.org
Subject:   Re: ports/47716: ports Makefile CFLAGS substituted incorrectly
Message-ID:  <20030131141747.17fae13a.corecode@corecode.ath.cx>
In-Reply-To: <1044002032.274.64.camel@asa.gascom.net.ru>
References:  <1044002032.274.64.camel@asa.gascom.net.ru>

next in thread | previous in thread | raw e-mail | index | archive | help
--H5=.IHLIlhCUqxcM
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Lately Akifyev Sergey told:

> >Description:
> Standard ports system makefile (bsd.port.mk) incorrectly appends
> CFLAGS variable from /etc/make.conf to CFLAGS with which port is to be
> compiled.

no, this is done in the port's Makefile (most time not even in the port
Makefile. duh, you know what i mean; the upstream Makefile)

> It should include one space character before CFLAGS value, to be sure
> that it will not produce "glued" arguments. In many ports, system
> exported CFLAGS is also appended without space, so it produces
> compiler arguments like:

then this is a big bug[tm]. ports/upstream Makefiles should be fixed IMO

cheers
  simon

-- 
/"\   http://corecode.ath.cx/#donate
\ /
 \     ASCII Ribbon Campaign
/ \  Against HTML Mail and News

--H5=.IHLIlhCUqxcM
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)

iD8DBQE+Ond/r5S+dk6z85oRAhonAKCXXLJLICiXVjcRYuL9XADzGpjsKwCeJ55R
s4cctHjvGE6XyZdyWXmh8HU=
=HcnK
-----END PGP SIGNATURE-----

--H5=.IHLIlhCUqxcM--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030131141747.17fae13a.corecode>