Date: 12 Feb 2003 11:32:48 -0500 From: Joe Marcus Clarke <marcus@FreeBSD.org> To: Franz Klammer <klammer@webonaut.com> Cc: FreeBSD GNOME Users <gnome@FreeBSD.org> Subject: Re: HEADS UP: Removing GNOMENG Message-ID: <1045067568.308.2.camel@gyros> In-Reply-To: <1045047331.663.10.camel@ds9.webonaut.com> References: <1044991950.305.36.camel@gyros> <1044996271.644.97.camel@ds9.webonaut.com> <1045018703.89844.13.camel@shumai.marcuscom.com> <1045047331.663.10.camel@ds9.webonaut.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-0vCwV/oFrUhSRbnpAedw Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, 2003-02-12 at 05:55, Franz Klammer wrote: > Am Mi, 2003-02-12 um 03.58 schrieb Joe Marcus Clarke: > > On Tue, 2003-02-11 at 15:44, Franz Klammer wrote: > > > Am Di, 2003-02-11 um 20.32 schrieb Joe Marcus Clarke: > > > > Okay, here is my release candidate diff for removing need for the > > > > GNOMENG keyword, and adding GNOME 2 support to the new GNOME portin= g > > > > infrastructure. This patch applies directly to ports/Mk/bsd.gnome.= mk, > > > > and removes the need for the bsd.gnomeng.mk file. =20 > > > >=20 > > > > I'd like to commit this tomorrow if possible. Please let me know i= f you > > > > see of foresee any problems. Thanks. > > > >=20 > > >=20 > > > work well for me with file_menu_applet. > > > i've deleted the older mails about this (maybe you have written about= ) > > > but why you don't include a kind of auto detection as additional safe= ty. > >=20 > > Give this diff a try. It adds such a check. I haven't done any testin= g > > yet, though. > >=20 >=20 > OK! it works. > done test with and without WITH_GNOME_DESKTOP=3D[1|2] and it works=20 > like expected. I was doing some more thinking about this, and I think setting it for the user is a bad idea. Think of the upgrade and downgrade scenarios.=20 Let's say the user is upgrading to GNOME 2. They won't have gnomepanel installed, but they will have libpanel installed. Therefore, all their GNOME 2 desktop bits will be broken. =20 I think it's safer to force the user to make a conscious decision to about which GNOME desktop version they want. This will prevent breakage in places we don't want. >=20 > FYI: i've only made one test with file_menu_applet.=20 > anything else i should check? Check as much as you can. Joe >=20 > franz. >=20 > > Joe > >=20 > > >=20 > > > eg:=20 > > >=20 > > > (ok! i know, that's not the correct syntax ;) > > >=20 > > > if !defined(WITH_GNOME_DESKTOP); then > > > if exists ../libpanelapplet-2.0.pc; then > > > WITH_GNOME_DESKTOP=3D2 > > > else > > > WITH_GNOME_DESKTOP=3D1 > > > endif > > > endif > > >=20 > > > sorry if this mail is a "argh! we already discussed about that!". > > > i was too lazy to look into the archive.=20 > > >=20 > > > attached the patch that removes GNOMENG and the gnome1-check=20 > > > from file_menu_applet.=20 > > >=20 > > > franz. > > >=20 > > > > Joe --=20 Joe Marcus Clarke FreeBSD GNOME Team :: marcus@FreeBSD.org http://www.FreeBSD.org/gnome --=-0vCwV/oFrUhSRbnpAedw Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQA+Sncwb2iPiv4Uz4cRAvKKAJ9Q/7SJS3C92dQRyTz9x+dtOCtBAQCgp3z1 ujgQYLzR2zBGKv1ILtep0Gk= =A+52 -----END PGP SIGNATURE----- --=-0vCwV/oFrUhSRbnpAedw-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-gnome" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1045067568.308.2.camel>