Date: Mon, 21 Jul 2014 21:48:31 +0400 From: Ilya A. Arkhipov <rum1cro@ya.ru> To: Nikolai Lifanov <lifanov@mail.lifanov.com>, Steven Hartland <killing@multiplay.co.uk> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Xin LI <delphij@freebsd.org> Subject: Re: svn commit: r268855 - in head: cddl/contrib/opensolaris/cmd/ztest sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys Message-ID: <9780681405964911@web23g.yandex.ru> In-Reply-To: <1048c8cc25685b1216b0f1714c4494f1@mail.lifanov.com> References: <201407182041.s6IKffMR077972@svn.freebsd.org> <5d0810f5950150ef60044acf239adb4a@mail.lifanov.com> <09AF6051EC3848B6B691A5570B5B065E@multiplay.co.uk> <1048c8cc25685b1216b0f1714c4494f1@mail.lifanov.com>
next in thread | previous in thread | raw e-mail | index | archive | help
21.07.2014, 07:50, "Nikolai Lifanov" <lifanov@mail.lifanov.com>: > On 2014-07-20 22:56, Steven Hartland wrote: >> š----- Original Message ----- From: "Nikolai Lifanov" >> š<lifanov@mail.lifanov.com> >> šTo: "Xin LI" <delphij@freebsd.org> >> šCc: <src-committers@freebsd.org>; <svn-src-head@freebsd.org> >> šSent: Monday, July 21, 2014 2:22 AM >> šSubject: Re: svn commit: r268855 - in head: >> šcddl/contrib/opensolaris/cmd/ztest >> šsys/cddl/contrib/opensolaris/uts/common/fs/zfs >> šsys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys >>> šOn 2014-07-18 16:41, Xin LI wrote: >>>> šAuthor: delphij >>>> šDate: Fri Jul 18 20:41:40 2014 >>>> šNew Revision: 268855 >>>> šURL: http://svnweb.freebsd.org/changeset/base/268855 >>>> >>>> šLog: >>>> šššMFV r268848: >>>> >>>> šššInstead of asserting all zio's be properly aligned, only assert >>>> šššon the logical ones. >>>> >>>> šššCap uberblocks at 8k, otherwise with ashift=17, there would be >>>> šššonly one uberblock. >>>> >>>> šššThis fixes a problem that zdb would trip assert on pools with >>>> šššashift >= 0xe (8k). >>>> >>>> šššWhile there, also change the code so it only attempt to condense >>>> šššspace map unless the uncondensed size consumes greater than >>>> šššzfs_metaslab_condense_block_threshold blocks. >>>> >>>> šššIllumos issue: >>>> ššššš4958 zdb trips assert on pools with ashift >= 0xe >>>> >>>> šššMFC after: 2 weeks >>> šThis specific commit makes boot hang just before mounting the root >>> šdataset for me when vfs.zfs.vdev.cache.size tunable is set. Unsetting >>> šthis tunable or reverting this commit (currently running r268933 minus >>> šr268855) fixes the boot for me. >>> >>> šPlease let me know if I can provide any more information. >> šInteresting, is there a reason you enabled vdev caching as its been >> šdisabled by default for quite some time with the comment: >> >> š* TODO: Note that with the current ZFS code, it turns out that the >> š* vdev cache is not helpful, and in some cases actually harmful. šIt >> š* is better if we disable this. šOnce some time has passed, we should >> š* actually remove this to simplify the code. šFor now we just disable >> š* it by setting the zfs_vdev_cache_size to zero. šNote that Solaris 11 >> š* has made these same changes. >> >> ššššRegards >> ššššSteve >> >> š_______________________________________________ >> šsvn-src-head@freebsd.org mailing list >> šhttp://lists.freebsd.org/mailman/listinfo/svn-src-head >> šTo unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" > > I noticed that it was disabled on default and I'm not seeing any ill > effect now that I have it disabled. I don't find vdev cache beneficial, > but I had it in my loader.conf for some time, and I had to remove it to > get the system to boot. If it's going to be broken going forward, > perhaps it's worthwhile to just remove the tunable? > > - Nikolai Lifanov > _______________________________________________ > svn-src-head@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" Hi All, Looks like I got error related with this commit. Before loading kernel(after installworld) I get error with "zfs unsupported ..."(can't get full error message so fast have reboot) Trying upgrade r256311 to r268939(loading from pxe and rollback solve this problem ^_^). Some one have the same issue? -- With Best Regards, Ilya A. Arkhipov
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9780681405964911>