Date: Fri, 11 Apr 1997 14:22:45 -0700 (MST) From: Terry Lambert <terry@lambert.org> To: phk@dk.tfs.com Cc: terry@lambert.org, current@freebsd.org Subject: Re: WHY? ...non-use of TAILQ macros... Message-ID: <199704112122.OAA12385@phaeton.artisoft.com> In-Reply-To: <1094.860742468@critter> from "phk@dk.tfs.com" at Apr 11, 97 09:07:48 am
next in thread | previous in thread | raw e-mail | index | archive | help
> >On the theory that the TAILQ_xxx macros were being avoided and the > >queue elemments themselves directly refernce for No Good Reason(tm), > >I just compiled the following: > > You're way behind Terry! :-) > > I argued this long time ago and started to introduce the _FIRST, _LAST, > _NEXT, _PREV and _EMPTY macros as I have got to it. > > A patch for this from you would be most welcome of course. I am maintaining several source trees right now on the machine where I have the post-Lite2 merged source repository. I don't have another 10M for another checked out tree, unless I want to truncate some of my build environment. I assume you would want me to run a kernel with these patches installed to make sure it runs and that there are no obvious memory leaks, etc.? Unfortunately, the post Lite2 merge tree on my machine has already got local modifications to bring the namei/nameifree and EXCLUDE vop flag code up to date with -current (I have uploaded today the diffs as taken against the -current tree; they are on freefall in the file ~terry/current-namei.diff). I could do the patch for the macro references (the mail message I sent in this thread already had most of the replacement lines that would result, already, for all tqh_first reference in /sys/kern), but it touches several of the same files, so I would not be able to give you a clean diff without including the namei/nameifree and EXCLUDE stuff. Too bad I can't just branch and check in my changes and check out an untouched tree... CVS is too dumb to let me unbranch later, and the next CVSup would kill me anyway. 8-(. Regards, Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199704112122.OAA12385>