Date: Thu, 29 Sep 2005 13:03:39 -0400 From: John Baldwin <jhb@FreeBSD.org> To: freebsd-current@freebsd.org Cc: Alex Lyashkov <shadow@psoft.net>, Peter Edwards <peadar.edwards@gmail.com> Subject: Re: biodone panics Message-ID: <200509291303.41181.jhb@FreeBSD.org> In-Reply-To: <1127978233.3383.12.camel@berloga.shadowland> References: <34cb7c8405092815247dc89bf6@mail.gmail.com> <1127978233.3383.12.camel@berloga.shadowland>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 29 September 2005 03:17 am, Alex Lyashkov wrote:
> > > biodone(struct bio *bp)
> > > {
> > > void (*done)(struct bio *);
> > >
> > > mtx_lock(&bdonelock);
> > > bp->bio_flags |= BIO_DONE;
> > > done = bp->bio_done
> > > if (done == NULL)
> > > wakeup(bp);
> > > mtx_unlock(&bdonelock);
> > > if (done != NULL)
> > > bp->bio_done(bp);
>
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> posible it should be
> if(done != NULL)
> done(bp);
> ?
Note that since he only does the wakeup of done is NULL, so I think it's ok as
is.
--
John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200509291303.41181.jhb>