Date: Mon, 8 Nov 2021 18:28:27 +0100 From: Juraj Lutter <otis@FreeBSD.org> To: d@delphij.net Cc: ports@freebsd.org Subject: Re: cyrus-sasl dependency in bsd.ldap.mk Message-ID: <F2C6F513-B7DA-4ABE-8B00-FED0D726315B@FreeBSD.org> In-Reply-To: <11853a40-85dc-e562-8883-1f1d3a7a7d20@delphij.net> References: <6F18C72A-D3FF-4135-9E7B-24D423F8489F@FreeBSD.org> <11853a40-85dc-e562-8883-1f1d3a7a7d20@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_99BE8861-CF63-48B3-ACA2-14AEE8B5D149
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=utf-8
> On 8 Nov 2021, at 18:17, Xin Li <delphij@delphij.net> wrote:
>=20
> On 11/8/21 05:39, Juraj Lutter wrote:
>> Hi Delphij,
>> you seem to be the most active in bsd.ldap.mk :-)
>> I=E2=80=99ve found that since openldap-client also depends on =
cyrus-sasl unconditionally, bsd.ldap.mk requires this:
>> otis@b13:/usr/ports/Mk % git diff -- bsd.ldap.mk
>> diff --git a/Mk/bsd.ldap.mk b/Mk/bsd.ldap.mk
>> index a6f37dd99b10..7acbc9c660bb 100644
>> --- a/Mk/bsd.ldap.mk
>> +++ b/Mk/bsd.ldap.mk
>> @@ -77,6 +77,7 @@ IGNORE=3D cannot install: doesn't =
work with OpenLDAP version: ${OPENLDAP_VER} (Do
>> . endfor
>> .endif # IGNORE_WITH_OPENLDAP
>> LIB_DEPENDS+=3D =
${OPENLDAP${OPENLDAP_VER}_LIB}:net/openldap${OPENLDAP_VER}-client
>> +LIB_DEPENDS+=3D libsasl2.so:security/cyrus-sasl2
>> .else
>> IGNORE=3D cannot install: unknown OpenLDAP version: =
${OPENLDAP_VER}
>> .endif # Check for correct libs
>> What are you thought about it?
>=20
> Could you provide an example that shows the breakage or elaborate more =
about why libsasl2.so needs to be listed as a direct library dependency =
for ports that depends on OpenLDAP? It's already listed as LIB_DEPENDS =
in openldap*-{server,client} and installing the library should =
automatically bring in cyrus-sasl as needed, no?
In fact, I was only looking for a solution to silence this:
=3D=3D=3D=3D> Running Q/A tests (stage-qa)
Error: /usr/local/lib/postfix/postfix-ldap.so is linked to =
/usr/local/lib/libsasl2.so.3 from security/cyrus-sasl2 but it is not =
declared as a dependency
Warning: you need LIB_DEPENDS+=3Dlibsasl2.so:security/cyrus-sasl2
And even when LDAP is being pulled in via LIB_DEPENDS in bsd.ldap.mk, =
there is no explicit dependency on cyrus-sasl2.
What would be the better approach? Given that bsd.ldap.mk is not the =
right place.
Thanks.
=E2=80=94
Juraj Lutter
otis@FreeBSD.org
--Apple-Mail=_99BE8861-CF63-48B3-ACA2-14AEE8B5D149
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=signature.asc
Content-Type: application/pgp-signature;
name=signature.asc
Content-Description: Message signed with OpenPGP
-----BEGIN PGP SIGNATURE-----
iHUEAREIAB0WIQR9WLqI3W4V0bRHtaAtyIKFszIZVAUCYYleOwAKCRAtyIKFszIZ
VBtDAQCp6+h/S4TPUQiN70CAO1ezoXTCRca6fkl4qfnQ4AzEKwD/cLW9hlq5xhE7
U8ZNVZaVajnBAI89AfyTyGOCmwtOrDk=
=4s5r
-----END PGP SIGNATURE-----
--Apple-Mail=_99BE8861-CF63-48B3-ACA2-14AEE8B5D149--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F2C6F513-B7DA-4ABE-8B00-FED0D726315B>