Date: Sun, 24 May 2009 19:01:31 +0300 From: Ion-Mihai Tetcu <itetcu@FreeBSD.org> To: pav@FreeBSD.org Cc: pgollucci@p6m7g8.com, naylor.b.david@gmail.com, freebsd-ports@FreeBSD.org Subject: Re: MAKE_JOBS_UNSAFE (some more ports) Message-ID: <20090524190131.0b30b101@it.buh.tecnik93.com> In-Reply-To: <1243174223.18007.2.camel@hood.oook.cz> References: <20090522.195350.193746535.chat95@mac.com> <20090522164138.236cb114@it.buh.tecnik93.com> <200905231101.59467.naylor.b.david@gmail.com> <20090523.182426.193741786.chat95@mac.com> <20090523135133.71a92669@it.buh.tecnik93.com> <1243174223.18007.2.camel@hood.oook.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/7MgcjWm/U1LmeErt+ZssHzg Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 24 May 2009 16:10:23 +0200 Pav Lucistnik <pav@FreeBSD.org> wrote: > Ion-Mihai Tetcu p=C3=AD=C5=A1e v so 23. 05. 2009 v 13:51 +0300: >=20 > > > > - MAKE_JOBS_NUMBER defaults (but user defined) to number of > > > > cores > >=20 > > This part looks OK, I wonder if there's any reason t ain't like this > > now; Pav? > > -.if defined(MAKE_JOBS_NUMBER) > > +MAKE_JOBS_NUMBER?=3D `${SYSCTL} -n kern.smp.cpus` > > _MAKE_JOBS=3D -j${MAKE_JOBS_NUMBER} > > -.else > > -_MAKE_JOBS=3D -j`${SYSCTL} -n kern.smp.cpus` > > -.endif >=20 > Wouldn't that mean an evaluation of the backtick command in every > make(1) invocation? That would be highly undesirable. Umm, why? it shouldn't be evaluated if MAKE_JOBS_NUMBER is defined, no? Am I missing some make magic here? --=20 IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" FreeBSD committer -> itetcu@FreeBSD.org, PGP Key ID 057E9F8B493A297B --Sig_/7MgcjWm/U1LmeErt+ZssHzg Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEARECAAYFAkoZb1wACgkQJ7GIuiH/oeU9qQCgo83Jrz/L7sKdx0zCJ5JNFJyO n58An2D7FYyz/ATv8ZnmOIQIrtqRaYXv =ITEA -----END PGP SIGNATURE----- --Sig_/7MgcjWm/U1LmeErt+ZssHzg--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090524190131.0b30b101>