Date: Tue, 20 Dec 2011 03:02:52 -0600 From: Alan Cox <alc@rice.edu> To: Sean Bruno <seanbru@yahoo-inc.com> Cc: "xen@freebsd.org" <xen@freebsd.org> Subject: Re: PV i386 patch Message-ID: <4EF04F3C.9010309@rice.edu> In-Reply-To: <1324339762.3093.14.camel@hitfishpass-lx.corp.yahoo.com> References: <4EEB9CCE.6090701@rice.edu> <1324169806.3093.3.camel@hitfishpass-lx.corp.yahoo.com> <4EED4982.3080208@freebsd.org> <1324339762.3093.14.camel@hitfishpass-lx.corp.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------070407040800020809060200 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/19/2011 18:09, Sean Bruno wrote: > On Sat, 2011-12-17 at 18:01 -0800, Colin Percival wrote: >> On 12/17/11 16:56, Sean Bruno wrote: >>> This seems happy on our ref9 VMs. I don't suppose this means I can go >>> above 768M of Ram now? >> Can't hurt to try... whatever the problem is with our code and large >> amounts of RAM, the fact that it's an insta-panic during paging setup >> suggests that it's something at a similar level of fail. >> > Nope, insta panic ... early though. 768M works, 1024M panics. > > > > [root@xen1 sbruno]# /usr/sbin/xm create -c ref9-xen32 > Using config file "/etc/xen/ref9-xen32". > Started domain ref9-xen32 (id=109) > WARNING: loader(8) metadata is missing! > GDB: no debug ports present > KDB: debugger backends: ddb > KDB: current backend: ddb > Copyright (c) 1992-2011 The FreeBSD Project. > Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994 > The Regents of the University of California. All rights > reserved. > FreeBSD is a registered trademark of The FreeBSD Foundation. > FreeBSD 9.0-PRERELEASE #0: Sat Dec 17 16:13:02 PST 2011 > > sbruno@ref9-xen32.freebsd.org:/dumpster/scratch/sbruno-scratch/9/sys/i386/compile/XEN i386 > WARNING: WITNESS option enabled, expect reduced performance. > panic: pmap_init: page table page is out of range > cpuid = 0 > KDB: enter: panic > [ thread pid 0 tid 0 ] > Stopped at 0xc0181d7a: movl $0,0xc0478174 > > > The code that panics shouldn't even exist in the Xen pmap. Try the attached patch. Alan --------------070407040800020809060200 Content-Type: text/plain; name="xen-pmap.c" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="xen-pmap.c" SW5kZXg6IHZtL3ZtX21hcC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHZtL3ZtX21hcC5jCShyZXZp c2lvbiAyMjg1NzApCisrKyB2bS92bV9tYXAuYwkod29ya2luZyBjb3B5KQpAQCAtNzgsNiAr NzgsNyBAQCBfX0ZCU0RJRCgiJEZyZWVCU0QkIik7CiAjaW5jbHVkZSA8c3lzL3JhY2N0Lmg+ CiAjaW5jbHVkZSA8c3lzL3Jlc291cmNldmFyLmg+CiAjaW5jbHVkZSA8c3lzL2ZpbGUuaD4K KyNpbmNsdWRlIDxzeXMvc2J1Zi5oPgkvKiBGb3Igc3lzY3RsX2tlcm5lbF9tYXAoKSAqLwog I2luY2x1ZGUgPHN5cy9zeXNjdGwuaD4KICNpbmNsdWRlIDxzeXMvc3lzZW50Lmg+CiAjaW5j bHVkZSA8c3lzL3NobS5oPgpAQCAtMzg5MCw2ICszODkxLDY1IEBAIHZtX21hcF9sb29rdXBf ZG9uZSh2bV9tYXBfdCBtYXAsIHZtX21hcF9lbnRyeV90IGVuCiAJdm1fbWFwX3VubG9ja19y ZWFkKG1hcCk7CiB9CiAKK3N0YXRpYyBpbnQgc3lzY3RsX2tlcm5lbF9tYXAoU1lTQ1RMX0hB TkRMRVJfQVJHUyk7CitTWVNDVExfT0lEKF92bSwgT0lEX0FVVE8sIGtlcm5lbF9tYXAsIENU TFRZUEVfU1RSSU5HIHwgQ1RMRkxBR19SRCwKKyAgICBOVUxMLCAwLCBzeXNjdGxfa2VybmVs X21hcCwgIkEiLCAiS2VybmVsIE1hcCBJbmZvIik7CisKK3N0YXRpYyBpbnQKK3N5c2N0bF9r ZXJuZWxfbWFwKFNZU0NUTF9IQU5ETEVSX0FSR1MpCit7CisJc3RydWN0IHNidWYgc2J1ZjsK Kwl2bV9tYXBfZW50cnlfdCBlbnRyeTsKKwl2bV9vZmZzZXRfdCB2YTsKKwl2bV9wYWRkcl90 IGxvY2tlZF9wYTsKKwl2bV9wYWdlX3QgbTsKKwljaGFyICpjYnVmOworCWNvbnN0IGludCBj YnVmc2l6ZSA9IGtlcm5lbF9tYXAtPm5lbnRyaWVzICogODE7CisJaW50IGVycm9yLCB4LCB5 OworCisJY2J1ZiA9IG1hbGxvYyhjYnVmc2l6ZSwgTV9URU1QLCBNX1dBSVRPSyB8IE1fWkVS Tyk7CisJc2J1Zl9uZXcoJnNidWYsIGNidWYsIGNidWZzaXplLCBTQlVGX0ZJWEVETEVOKTsK Kwlmb3IgKGVudHJ5ID0ga2VybmVsX21hcC0+aGVhZGVyLm5leHQ7IGVudHJ5ICE9ICZrZXJu ZWxfbWFwLT5oZWFkZXI7CisgICAgICAgICAgICBlbnRyeSA9IGVudHJ5LT5uZXh0KSB7CisJ CXggPSB5ID0gMDsKKwkJaWYgKChlbnRyeS0+ZWZsYWdzICYgTUFQX0VOVFJZX0lTX1NVQl9N QVApID09IDApCisJCWZvciAodmEgPSBlbnRyeS0+c3RhcnQ7IHZhIDwgZW50cnktPmVuZDsg dmEgPSAKKyNpZmRlZiBfX2FtZDY0X18KKwkJICAgIHJvdW5kXzJtcGFnZSh2YSArIDEpCisj ZWxzZQorCQkgICAgcm91bmRfNG1wYWdlKHZhICsgMSkKKyNlbmRpZgorCQkgICAgKSB7CisJ CQlpZiAodmEgPT0KKyNpZmRlZiBfX2FtZDY0X18KKwkJCSAgICB0cnVuY18ybXBhZ2UodmEp CisjZWxzZQorCQkJICAgIHRydW5jXzRtcGFnZSh2YSkKKyNlbmRpZgorCQkJICAgICkgewor CQkJCWxvY2tlZF9wYSA9IDA7CisJCQkJeCsrOworCQkJCWlmIChwbWFwX21pbmNvcmUoa2Vy bmVsX3BtYXAsIHZhLCAmbG9ja2VkX3BhKSAmCisJCQkJICAgIE1JTkNPUkVfU1VQRVIpCisJ CQkJCXkrKzsKKwkJCQlpZiAobG9ja2VkX3BhICE9IDApIHsKKwkJCQkJbSA9IFBIWVNfVE9f Vk1fUEFHRShsb2NrZWRfcGEpOworCQkJCQl2bV9wYWdlX3VubG9jayhtKTsKKwkJCQl9CisJ CQl9CisJCX0KKwkJc2J1Zl9wcmludGYoJnNidWYsICJcbnN0YXJ0PSVwLCBlbmQ9JXAsICVz PSVwICglZC8lZCkiLAorICAgICAgICAgICAgICAgICAgICAodm9pZCAqKWVudHJ5LT5zdGFy dCwgKHZvaWQgKillbnRyeS0+ZW5kLAorICAgICAgICAgICAgICAgICAgICAoZW50cnktPmVm bGFncyAmIE1BUF9FTlRSWV9JU19TVUJfTUFQKSA/ICJzdWJtYXAiIDogIm9iamVjdCIsCisg ICAgICAgICAgICAgICAgICAgIGVudHJ5LT5vYmplY3Qudm1fb2JqZWN0LCB4LCB5KTsKKwl9 CisJc2J1Zl9maW5pc2goJnNidWYpOworCWVycm9yID0gU1lTQ1RMX09VVChyZXEsIHNidWZf ZGF0YSgmc2J1ZiksIHNidWZfbGVuKCZzYnVmKSk7CisJc2J1Zl9kZWxldGUoJnNidWYpOwor CWZyZWUoY2J1ZiwgTV9URU1QKTsKKwlyZXR1cm4gKGVycm9yKTsKK30KKwogI2luY2x1ZGUg Im9wdF9kZGIuaCIKICNpZmRlZiBEREIKICNpbmNsdWRlIDxzeXMva2VybmVsLmg+CkluZGV4 OiB2bS92bV9vYmplY3QuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB2bS92bV9vYmplY3QuYwkocmV2 aXNpb24gMjI4NTcwKQorKysgdm0vdm1fb2JqZWN0LmMJKHdvcmtpbmcgY29weSkKQEAgLTEz MDgsNiArMTMwOCwxNCBAQCByZXRyeToKIAkJCVZNX09CSkVDVF9MT0NLKG5ld19vYmplY3Qp OwogCQkJZ290byByZXRyeTsKIAkJfQorI2lmIDAKKyNpZiBWTV9OUkVTRVJWTEVWRUwgPiAw CisJCS8qCisJCSAqIFJlbmFtZSB0aGUgcmVzZXJ2YXRpb24uCisJCSAqLworCQl2bV9yZXNl cnZfcmVuYW1lKG0sIG5ld19vYmplY3QsIG9yaWdfb2JqZWN0LCBvZmZpZHhzdGFydCk7Cisj ZW5kaWYKKyNlbmRpZgogCQl2bV9wYWdlX2xvY2sobSk7CiAJCXZtX3BhZ2VfcmVuYW1lKG0s IG5ld19vYmplY3QsIGlkeCk7CiAJCXZtX3BhZ2VfdW5sb2NrKG0pOwpJbmRleDogaTM4Ni94 ZW4vbXBfbWFjaGRlcC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGkzODYveGVuL21wX21hY2hkZXAu YwkocmV2aXNpb24gMjI4NTcwKQorKysgaTM4Ni94ZW4vbXBfbWFjaGRlcC5jCSh3b3JraW5n IGNvcHkpCkBAIC04MTAsNyArODEwLDcgQEAgY3B1X2luaXRpYWxpemVfY29udGV4dCh1bnNp Z25lZCBpbnQgY3B1KQogewogCS8qIHZjcHVfZ3Vlc3RfY29udGV4dF90IGlzIHRvbyBsYXJn ZSB0byBhbGxvY2F0ZSBvbiB0aGUgc3RhY2suCiAJICogSGVuY2Ugd2UgYWxsb2NhdGUgc3Rh dGljYWxseSBhbmQgcHJvdGVjdCBpdCB3aXRoIGEgbG9jayAqLwotCXZtX3BhZ2VfdCBtWzRd OworCXZtX3BhZ2VfdCBtW05QR1BURCArIDJdOwogCXN0YXRpYyB2Y3B1X2d1ZXN0X2NvbnRl eHRfdCBjdHh0OwogCXZtX29mZnNldF90IGJvb3Rfc3RhY2s7CiAJdm1fb2Zmc2V0X3QgbmV3 UFREOwpAQCAtODMxLDggKzgzMSw4IEBAIGNwdV9pbml0aWFsaXplX2NvbnRleHQodW5zaWdu ZWQgaW50IGNwdSkKIAkJcG1hcF96ZXJvX3BhZ2UobVtpXSk7CiAKIAl9Ci0JYm9vdF9zdGFj ayA9IGttZW1fYWxsb2Nfbm9mYXVsdChrZXJuZWxfbWFwLCAxKTsKLQluZXdQVEQgPSBrbWVt X2FsbG9jX25vZmF1bHQoa2VybmVsX21hcCwgTlBHUFREKTsKKwlib290X3N0YWNrID0ga21l bV9hbGxvY19ub2ZhdWx0KGtlcm5lbF9tYXAsIFBBR0VfU0laRSk7CisJbmV3UFREID0ga21l bV9hbGxvY19ub2ZhdWx0KGtlcm5lbF9tYXAsIE5QR1BURCAqIFBBR0VfU0laRSk7CiAJbWFb MF0gPSBWTV9QQUdFX1RPX01BQ0gobVswXSl8UEdfVjsKIAogI2lmZGVmIFBBRQkKQEAgLTg1 NCw3ICs4NTQsNyBAQCBjcHVfaW5pdGlhbGl6ZV9jb250ZXh0KHVuc2lnbmVkIGludCBjcHUp CiAJICAgIG5rcHQqc2l6ZW9mKHZtX3BhZGRyX3QpKTsKIAogCXBtYXBfcXJlbW92ZShuZXdQ VEQsIDQpOwotCWttZW1fZnJlZShrZXJuZWxfbWFwLCBuZXdQVEQsIDQpOworCWttZW1fZnJl ZShrZXJuZWxfbWFwLCBuZXdQVEQsIDQgKiBQQUdFX1NJWkUpOwogCS8qCiAJICogbWFwIGFj dHVhbCBpZGxlIHN0YWNrIHRvIGJvb3Rfc3RhY2sKIAkgKi8KSW5kZXg6IGkzODYveGVuL3Bt YXAuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBpMzg2L3hlbi9wbWFwLmMJKHJldmlzaW9uIDIyODU3 MCkKKysrIGkzODYveGVuL3BtYXAuYwkod29ya2luZyBjb3B5KQpAQCAtMTg0LDkgKzE4NCw2 IEBAIF9fRkJTRElEKCIkRnJlZUJTRCQiKTsKICNkZWZpbmUgUFZfU1RBVCh4KQlkbyB7IH0g d2hpbGUgKDApCiAjZW5kaWYKIAotI2RlZmluZQlwYV9pbmRleChwYSkJKChwYSkgPj4gUERS U0hJRlQpCi0jZGVmaW5lCXBhX3RvX3B2aChwYSkJKCZwdl90YWJsZVtwYV9pbmRleChwYSld KQotCiAvKgogICogR2V0IFBERXMgYW5kIFBURXMgZm9yIHVzZXIva2VybmVsIGFkZHJlc3Mg c3BhY2UKICAqLwpAQCAtMjMwLDcgKzIyNyw2IEBAIHN0YXRpYyBpbnQgcGF0X3dvcmtzOwkJ CS8qIElzIHBhZ2UgYXR0cmlidXRlIHRhYmxlCiAgKiBEYXRhIGZvciB0aGUgcHYgZW50cnkg YWxsb2NhdGlvbiBtZWNoYW5pc20KICAqLwogc3RhdGljIGludCBwdl9lbnRyeV9jb3VudCA9 IDAsIHB2X2VudHJ5X21heCA9IDAsIHB2X2VudHJ5X2hpZ2hfd2F0ZXIgPSAwOwotc3RhdGlj IHN0cnVjdCBtZF9wYWdlICpwdl90YWJsZTsKIHN0YXRpYyBpbnQgc2hwZ3BlcnByb2MgPSBQ TUFQX1NIUEdQRVJQUk9DOwogCiBzdHJ1Y3QgcHZfY2h1bmsgKnB2X2NodW5rYmFzZTsJCS8q IEtWQSBibG9jayBmb3IgcHZfY2h1bmtzICovCkBAIC02MzYsMjQgKzYzMiw4IEBAIHBtYXBf cHRlbGlzdF9pbml0KHZtX29mZnNldF90ICpoZWFkLCB2b2lkICpiYXNlLCBpCiB2b2lkCiBw bWFwX2luaXQodm9pZCkKIHsKLQl2bV9wYWdlX3QgbXB0ZTsKLQl2bV9zaXplX3QgczsKLQlp bnQgaSwgcHZfbnBnOwogCiAJLyoKLQkgKiBJbml0aWFsaXplIHRoZSB2bSBwYWdlIGFycmF5 IGVudHJpZXMgZm9yIHRoZSBrZXJuZWwgcG1hcCdzCi0JICogcGFnZSB0YWJsZSBwYWdlcy4K LQkgKi8gCi0JZm9yIChpID0gMDsgaSA8IG5rcHQ7IGkrKykgewotCQltcHRlID0gUEhZU19U T19WTV9QQUdFKHhwbWFwX210b3AoUFREW2kgKyBLUFRESV0gJiBQR19GUkFNRSkpOwotCQlL QVNTRVJUKG1wdGUgPj0gdm1fcGFnZV9hcnJheSAmJgotCQkgICAgbXB0ZSA8ICZ2bV9wYWdl X2FycmF5W3ZtX3BhZ2VfYXJyYXlfc2l6ZV0sCi0JCSAgICAoInBtYXBfaW5pdDogcGFnZSB0 YWJsZSBwYWdlIGlzIG91dCBvZiByYW5nZSIpKTsKLQkJbXB0ZS0+cGluZGV4ID0gaSArIEtQ VERJOwotCQltcHRlLT5waHlzX2FkZHIgPSB4cG1hcF9tdG9wKFBURFtpICsgS1BUREldICYg UEdfRlJBTUUpOwotCX0KLQotICAgICAgICAvKgogCSAqIEluaXRpYWxpemUgdGhlIGFkZHJl c3Mgc3BhY2UgKHpvbmUpIGZvciB0aGUgcHYgZW50cmllcy4gIFNldCBhCiAJICogaGlnaCB3 YXRlciBtYXJrIHNvIHRoYXQgdGhlIHN5c3RlbSBjYW4gcmVjb3ZlciBmcm9tIGV4Y2Vzc2l2 ZQogCSAqIG51bWJlcnMgb2YgcHYgZW50cmllcy4KQEAgLTY2NCwyNiArNjQ0LDYgQEAgcG1h cF9pbml0KHZvaWQpCiAJcHZfZW50cnlfbWF4ID0gcm91bmR1cChwdl9lbnRyeV9tYXgsIF9O UENQVik7CiAJcHZfZW50cnlfaGlnaF93YXRlciA9IDkgKiAocHZfZW50cnlfbWF4IC8gMTAp OwogCi0JLyoKLQkgKiBBcmUgbGFyZ2UgcGFnZSBtYXBwaW5ncyBlbmFibGVkPwotCSAqLwot CVRVTkFCTEVfSU5UX0ZFVENIKCJ2bS5wbWFwLnBnX3BzX2VuYWJsZWQiLCAmcGdfcHNfZW5h YmxlZCk7Ci0KLQkvKgotCSAqIENhbGN1bGF0ZSB0aGUgc2l6ZSBvZiB0aGUgcHYgaGVhZCB0 YWJsZSBmb3Igc3VwZXJwYWdlcy4KLQkgKi8KLQlmb3IgKGkgPSAwOyBwaHlzX2F2YWlsW2kg KyAxXTsgaSArPSAyKTsKLQlwdl9ucGcgPSByb3VuZF80bXBhZ2UocGh5c19hdmFpbFsoaSAt IDIpICsgMV0pIC8gTkJQRFI7Ci0KLQkvKgotCSAqIEFsbG9jYXRlIG1lbW9yeSBmb3IgdGhl IHB2IGhlYWQgdGFibGUgZm9yIHN1cGVycGFnZXMuCi0JICovCi0JcyA9ICh2bV9zaXplX3Qp KHB2X25wZyAqIHNpemVvZihzdHJ1Y3QgbWRfcGFnZSkpOwotCXMgPSByb3VuZF9wYWdlKHMp OwotCXB2X3RhYmxlID0gKHN0cnVjdCBtZF9wYWdlICopa21lbV9hbGxvYyhrZXJuZWxfbWFw LCBzKTsKLQlmb3IgKGkgPSAwOyBpIDwgcHZfbnBnOyBpKyspCi0JCVRBSUxRX0lOSVQoJnB2 X3RhYmxlW2ldLnB2X2xpc3QpOwotCiAJcHZfbWF4Y2h1bmtzID0gTUFYKHB2X2VudHJ5X21h eCAvIF9OUENQViwgbWF4cHJvYyk7CiAJcHZfY2h1bmtiYXNlID0gKHN0cnVjdCBwdl9jaHVu ayAqKWttZW1fYWxsb2Nfbm9mYXVsdChrZXJuZWxfbWFwLAogCSAgICBQQUdFX1NJWkUgKiBw dl9tYXhjaHVua3MpOwpAQCAtMzQ0OCwyMSArMzQwOCwxNSBAQCBwbWFwX3BhZ2Vfd2lyZWRf bWFwcGluZ3Modm1fcGFnZV90IG0pCiB9CiAKIC8qCi0gKiBSZXR1cm5zIFRSVUUgaWYgdGhl IGdpdmVuIHBhZ2UgaXMgbWFwcGVkIGluZGl2aWR1YWxseSBvciBhcyBwYXJ0IG9mCi0gKiBh IDRtcGFnZS4gIE90aGVyd2lzZSwgcmV0dXJucyBGQUxTRS4KKyAqIFJldHVybnMgVFJVRSBp ZiB0aGUgZ2l2ZW4gcGFnZSBpcyBtYXBwZWQuICBPdGhlcndpc2UsIHJldHVybnMgRkFMU0Uu CiAgKi8KIGJvb2xlYW5fdAogcG1hcF9wYWdlX2lzX21hcHBlZCh2bV9wYWdlX3QgbSkKIHsK LQlib29sZWFuX3QgcnY7CiAKIAlpZiAoKG0tPm9mbGFncyAmIFZQT19VTk1BTkFHRUQpICE9 IDApCiAJCXJldHVybiAoRkFMU0UpOwotCXZtX3BhZ2VfbG9ja19xdWV1ZXMoKTsKLQlydiA9 ICFUQUlMUV9FTVBUWSgmbS0+bWQucHZfbGlzdCkgfHwKLQkgICAgIVRBSUxRX0VNUFRZKCZw YV90b19wdmgoVk1fUEFHRV9UT19QSFlTKG0pKS0+cHZfbGlzdCk7Ci0Jdm1fcGFnZV91bmxv Y2tfcXVldWVzKCk7Ci0JcmV0dXJuIChydik7CisJcmV0dXJuICghVEFJTFFfRU1QVFkoJm0t Pm1kLnB2X2xpc3QpKTsKIH0KIAogLyoK --------------070407040800020809060200--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EF04F3C.9010309>