Date: Mon, 18 Jun 2012 21:03:46 +0100 From: Chris Rees <crees@freebsd.org> To: Grzegorz Blach <magik@roorback.net> Cc: freebsd-ports-bugs@freebsd.org, FreeBSD-gnats-submit@freebsd.org Subject: Re: ports/169040: audio/ario: Converted to OptionsNG Message-ID: <CADLo838Etb8PxyGWc1zLB-9KajVMQWg2qcfz=OpxNHg=XEbUzA@mail.gmail.com> In-Reply-To: <1340048600.2070.8.camel@silver.nine> References: <201206131640.q5DGe9Cj057006@freefall.freebsd.org> <1340048600.2070.8.camel@silver.nine>
next in thread | previous in thread | raw e-mail | index | archive | help
On 18 June 2012 20:43, Grzegorz Blach <magik@roorback.net> wrote: > ario configuration now is broken: > > 1. OPTIONS_DEFINE= NLS override OPTIONS_DEFINE= AVAHI, so only NLS > option is available during 'make config' > > 2. AVAHI_DESC is defined in Mk/bsd.options.desc.mk, it isn't necessary > to override this variable with similar message > > 3. Porter handbook suggest use WITHOUT_NLS variable to choose using > gettext or not. Also I think /etc/make.conf is better place to set this > variable, than port Makefile, so I removed NLS option. NLS is also in PORT_OPTIONS, and the code handles it correctly; i.e. WITH_NLS in make.conf sets option NLS. I'll clarify the docs. Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo838Etb8PxyGWc1zLB-9KajVMQWg2qcfz=OpxNHg=XEbUzA>