Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 24 Jan 2013 20:19:16 -0500
From:      Eitan Adler <lists@eitanadler.com>
To:        "Isaac (.ike) Levy" <ike@blackskyresearch.net>
Cc:        freebsd-doc@freebsd.org
Subject:   Re: features.xml
Message-ID:  <CAF6rxg=_fY6pKAHkSTdbVP11a4dBw7os=1dyEWkOm9Vj1BCa8Q@mail.gmail.com>
In-Reply-To: <1359066182-9159790.08923608.fr0OMMIQq019536@rs149.luxsci.com>
References:  <CAF6rxgkbnKbUSuoruaVbHC285JXjdeJd1SjdCBCMBdRj-i2a9A@mail.gmail.com> <CAF6rxgn0W61-LGi4N8N9Bi71jE-WLwD-k5tfq4Obrcrt4zoTaQ@mail.gmail.com> <CAF6rxgk=fDAKQ4Hjq=KBBNKE4n4A=QmtD7YB5e9hFWW=saLoRw@mail.gmail.com> <70AFF504-314E-4F42-A2E1-D148D8FA2BCD@axialmarket.com> <CAF6rxg=rqEnkuabh46iYX%2BzMV2kV0M7=WteLe313m0QXxPA4pg@mail.gmail.com> <1359058203-4509368.00016252.fr0OK9rh7016372@rs149.luxsci.com> <alpine.BSF.2.00.1301241509300.86451@wonkity.com> <1359066182-9159790.08923608.fr0OMMIQq019536@rs149.luxsci.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 24 January 2013 17:22, Isaac (.ike) Levy <ike@blackskyresearch.net> wrote:
> On Jan 24, 2013, at 5:10 PM, Warren Block wrote:
>> On Thu, 24 Jan 2013, Isaac (.ike) Levy wrote:
>>> On Jan 24, 2013, at 12:09 PM, Eitan Adler wrote:
>>>
>>>> On 24 January 2013 12:07, Isaac (.ike) Levy <ike.levy@axialmarket.com> wrote:
>>>>>
>>>>> Would you like me to submit a patch back to list?  (Will get to it this weekend if so.)
>>>>
>>>> Please do!
>>>
>>>
>>> What is the accepted workflow for submitting a doc patch?
>>
>> Normally, it is:
>>
>>  get a local working copy with svn
>>  edit
>>  build test
>>  check
>>  use 'svn diff' to generate a diff
>>  submit in a PR
>
> Thank you Warren, that's easy.
>
> I'll follow that protocol from now on.
> (And I'll ditch the git bits, however much muscle-memory I have invested in it).

There is nothing wrong with git!  Feel free to use it (I do!).  The
only concern is to be aware that
- not everyone does
- the final result goes to svn

so the patches should be applicable by everyone.


That said - I'll take a closer look at your changes soon.  I'm about
to start classes so my free time will be somewhat variable.

-- 
Eitan Adler



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=_fY6pKAHkSTdbVP11a4dBw7os=1dyEWkOm9Vj1BCa8Q>