Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 03 Jul 2002 00:17:23 -0400 (EDT)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Andrew Gallatin <gallatin@cs.duke.edu>
Cc:        freebsd-current@freebsd.org, Julian Elischer <julian@elischer.org>
Subject:   Re: KSE signal problems still
Message-ID:  <XFMail.20020703001723.jhb@FreeBSD.org>
In-Reply-To: <15650.26618.523781.562050@grasshopper.cs.duke.edu>

next in thread | previous in thread | raw e-mail | index | archive | help

On 03-Jul-2002 Andrew Gallatin wrote:
> 
> Julian Elischer writes:
>  > > 
>  > > However, it does seem a bit silly, as we end up dropping
>  > > and-reaquiring the sched lock quite a few times:
>  > 
>  > That's why I just asked you to test the concept..
>  > If I know that just aquiring it here is ok, 
>  > (I presume you tried doing some work like this)
>  > that tells me that this code isn't called from some odd place,
>  > with the sched lock already set.
>  > 
>  > (that and code inspection of course..)
>  > 
>  > Now we know it works we can try optimise it..
>  > 
>  > I'm going home now for dinner, 
>  > so if you feel like checking this or something mor optimal in,
>  > be my guest :-)
> 
> OK, I've checked in the unoptimized fix.   Please do optimize it when
> you get a chance.

Erm, I thought I changd signotify() to require sched_lock and made the
second half of psignal() (the whole case statement) lock sched_lock.
Did you change that?  (To Julian)

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020703001723.jhb>