Date: Thu, 10 Aug 2006 12:09:44 -0600 From: John E Hein <jhein@timing.com> To: Brooks Davis <brooks@one-eyed-alien.net> Cc: ports@FreeBSD.org, G?bor K?vesd?n <gabor@FreeBSD.org> Subject: Re: support for DESTDIR: security/openssh-portable Message-ID: <17627.30312.666186.963319@gromit.timing.com> In-Reply-To: <17627.29470.997143.560213@gromit.timing.com> References: <17626.25183.846983.515718@gromit.timing.com> <17626.25444.563099.956775@gromit.timing.com> <44DA6FC9.3040404@FreeBSD.org> <17626.29481.909830.326948@gromit.timing.com> <17626.30422.650339.960580@gromit.timing.com> <20060810132105.GA20275@lor.one-eyed-alien.net> <44DB33D2.4070308@FreeBSD.org> <20060810140529.GB20275@lor.one-eyed-alien.net> <17627.29470.997143.560213@gromit.timing.com>
next in thread | previous in thread | raw e-mail | index | archive | help
John E Hein wrote at 11:55 -0600 on Aug 10, 2006:
> Brooks Davis wrote at 09:05 -0500 on Aug 10, 2006:
> > I think we should ideally introduce a feature to allow ports to
> > automatically run pkg-install and stuff the code in bsd.port.mk so
> > ports don't have to know about DESTDIR in this case.
>
> Yes. That'd be nice.
Clarifying 'nice'...
As you know, many custom install targets do:
${INSTALL_PROGRAM} foo ${PREFIX}/bin
Those should change to
${INSTALL_PROGRAM} foo ${DESTDIR}${PREFIX}/bin
or the shorthand:
${INSTALL_PROGRAM} foo ${TARGETDIR}/bin
So those ports need to know about DESTDIR anyway.
But I can't think of any reason offhand not to have the pkg-install
scripts run in the DESTDIR chroot so they wouldn't have to know about
DESTDIR.
And standardizing (in bsd.port.mk) how pkg-install is run from custom
*install targets would make the task of getting ports properly DESTDIR
compliant much easier.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?17627.30312.666186.963319>