Date: Tue, 21 Jun 2022 10:53:54 +0200 From: Stefan Esser <se@FreeBSD.org> To: Jim Pazarena <fports@paz.bz> Cc: ports@freebsd.org Subject: Re: devel/gindent compile issues on 13.1 Message-ID: <261bad60-979d-2464-8c95-0d84e8010383@FreeBSD.org> In-Reply-To: <17e3eae3-8e25-2bbb-3d78-995eeb2af74b@paz.bz> References: <17e3eae3-8e25-2bbb-3d78-995eeb2af74b@paz.bz>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------H0g31o8HcLwR0eO4dEM0nv8f Content-Type: multipart/mixed; boundary="------------c40E0yqcyKX2JE9lHfNnz00a"; protected-headers="v1" From: Stefan Esser <se@FreeBSD.org> To: Jim Pazarena <fports@paz.bz> Cc: ports@freebsd.org Message-ID: <261bad60-979d-2464-8c95-0d84e8010383@FreeBSD.org> Subject: Re: devel/gindent compile issues on 13.1 References: <17e3eae3-8e25-2bbb-3d78-995eeb2af74b@paz.bz> In-Reply-To: <17e3eae3-8e25-2bbb-3d78-995eeb2af74b@paz.bz> --------------c40E0yqcyKX2JE9lHfNnz00a Content-Type: multipart/mixed; boundary="------------6jHLgZ0xQz9680cD6uHKCzse" --------------6jHLgZ0xQz9680cD6uHKCzse Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 21.06.22 um 05:09 schrieb Jim Pazarena: > I did not file a bug report . > But I had hopes that after a month passed , someone , perhaps even the > maintainer , this issue would have been corrected . >=20 > Alas . >=20 > I can't be the only one that wants to pretty up their source , and uses= gindent > to do it . So is no one concerned that this utility fails to compile ? I do not use gindent, but I have looked into the build issue. There is parens_indent as local variable in dump_line_code(), which is only initialized and updated, but never used, and there is the global array parser_state_tos->paren_indents[], and that is actually used. Without trying to get a deep understanding of the code, I can only assume that the local variable has been found to not suffice to determine the correct indentation value, and that it has been replaced by the array, but without removal of the now unused local variable. I can update the port to not define and update parens_indent, but since I do not use that port and since I do not have the time and motivation to analyze the logic used, I can only point out how to make the port build, but will not commit the patch. If you want to give the patch a try you can save the attached file as devel/gindent/files/patch-src_output.c, replacing that file. I have only commented out the code that causes the build to break. A commit-ready patch would remove those lines from the sources. If this patch works for you after some testing, I'll update the patch to allow an official package to be built again. Regards, STefan --------------6jHLgZ0xQz9680cD6uHKCzse Content-Type: text/plain; charset=UTF-8; name="patch-src_output.c" Content-Disposition: attachment; filename="patch-src_output.c" Content-Transfer-Encoding: base64 LS0tIHNyYy9vdXRwdXQuYy5vcmlnCTIwMTgtMDktMDUgMTY6NDc6NTYgVVRDCisrKyBzcmMv b3V0cHV0LmMKQEAgLTc0LDcgKzc0LDcgQEAgUkNTVEFHX0NDICgiJElkJCIpOwogCiBSQ1NU QUdfQ0MgKCIkSWQkIik7CiAKLXN0YXRpYyBGSUxFICAgICAgICAgICAgKiBvdXRwdXQgICAg ICAgPSBOVUxMOworRklMRSAgICAgICAgICAgICAgICAgICAqIG91dHB1dCAgICAgICA9IE5V TEw7CiBzdGF0aWMgQk9PTEVBTiAgICAgICAgICAgaW5oaWJpdGVkICAgID0gMDsKIHN0YXRp YyBidWZfYnJlYWtfc3RfdHkgKiBidWZfYnJlYWtfbGlzdCA9IE5VTEw7CiBidWZfYnJlYWtf c3RfdHkgKiBidWZfYnJlYWsgPSBOVUxMOwpAQCAtODQwLDcgKzg0MCw3IEBAIHN0YXRpYyB2 b2lkIGR1bXBfbGluZV9jb2RlKAogICAgIEJPT0xFQU4gKiBwYnJlYWtfbGluZSwKICAgICBp bnQgICAgICAgdGFyZ2V0X2NvbF9icmVhaykKIHsKLSAgIGludCBwYXJlbl9sZXZlbCAgID0g MDsKKy8vICAgaW50IHBhcmVuX2xldmVsICAgPSAwOwogCiAgICBpZiAoc19jb2RlICE9IGVf Y29kZSkKICAgIHsgICAgICAgICAgICAgICAgICAgICAgIC8qIHByaW50IGNvZGUgc2VjdGlv biwgaWYgYW55ICovCkBAIC05MjgsNyArOTI4LDcgQEAgc3RhdGljIHZvaWQgZHVtcF9saW5l X2NvZGUoCiAKICAgICAgICAgICpwY3VyX2NvbCA9IGNvdW50X2NvbHVtbnMgKCpwY3VyX2Nv bCwgc19jb2RlLCBOVUxMX0NIQVIpOwogCi0gICAgICAgICBwYXJlbl9sZXZlbCArPSBjb3Vu dF9wYXJlbnMoc19jb2RlKTsKKy8vICAgICAgICAgcGFyZW5fbGV2ZWwgKz0gY291bnRfcGFy ZW5zKHNfY29kZSk7CiAKICAgICAgICAgIHNfY29kZVtidWZfYnJlYWstPm9mZnNldF0gPSBj OwogCg== --------------6jHLgZ0xQz9680cD6uHKCzse-- --------------c40E0yqcyKX2JE9lHfNnz00a-- --------------H0g31o8HcLwR0eO4dEM0nv8f Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmKxhyMFAwAAAAAACgkQR+u171r99UQ4 fQf+Iz38MCcr2OIIDcHvh78AMA6hzkJaLapxzpv+3xJVWDRygoB3sSJ+ngkCXixoTEMAnvpJUHwi /deAdSnKN2CXnJq7Co8hw2uGnUXup8lXnFAIzmfic2xvUKG50VVkqcGPclL1ZU+jFV9bjvONVq6x 8fsJccMNVcXpOiW6ToUPHGskHFgKElX5nISx7TEhq8qaRVzAOycIa2fgnnZ571EtaVEwHtbjzrI5 k9CS7vShA6wIXgWPGltfDKB7zF69ukliQcjGZRtq6892ydpbFdrBnu2c5VRF0j6etLk/7LJba+tk MVnDgUjW/5s7rH3XBsT7kjPkFyhrf/iP8bx21E/J8w== =bnO7 -----END PGP SIGNATURE----- --------------H0g31o8HcLwR0eO4dEM0nv8f--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?261bad60-979d-2464-8c95-0d84e8010383>