Date: Sun, 05 Mar 1995 14:32:30 -0800 From: "Jordan K. Hubbard" <jkh@freefall.cdrom.com> To: Steven Wallace <swallace@freefall.cdrom.com> Cc: CVS-commiters@freefall.cdrom.com, cvs-sys@freefall.cdrom.com, smpatel@wam.umd.edu Subject: Re: [your sound commits] Message-ID: <6114.794442750@freefall.cdrom.com> In-Reply-To: Your message of "Sun, 05 Mar 95 14:12:02 PST." <199503052212.OAA04172@freefall.cdrom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> Revert to earlier code which contains FreeBSD snd[1-7] probe information,
> $Id$ information, and other code to make sound driver compile and work
> correctly with FreeBSD.
So now just so I (and all of the rest of us, I'll assume) understand
this sequence correctly, let me see if I can document the history of
this somewhat confusion affair:
1. I basically import Sujal's changes blind and break the tree.
2. I also change his local.h stuff a little so that defining something
like AUDIO_SB16 also drags in AUDIO_SB, which seems to be necessary,
and make other sections of the code less dependant on AUDIO_SBPRO since
the absence of it causes a lot of sections to go away that are needed
by AUDIO_SB16. In short, I try to eliminate needless "hierarchy" where
it appears and introduce some where it's lacking (AUDIO_SB16 becomes a
superset). This all resulted in the tree at least compiling properly for
the SB16.
3. Sujan and I establish that things, while now compiling, are still pretty
broken and we begin a dialog for backing out parts of the soundcard.c
and dmabuf.c changes. I do so, but don't follow-up with a test since I
haven't managed to be anywhere near my SB16 card in the last 24 hours.
4. I see Steven's changes in my mailbox in the morning.
If you (Steven) have simply brought over Sujal's changes again but
with more actual thought put into the process then I applaud this
effort and thank you for stepping into a matter I was simply too busy
to handle (rather a LOT going on here right now, let me tell you!).
If you've simply spammed my changes in #2, then I urge you to discuss
this with Sujal and Andrew so that you can some up with some other
solution for the "hierarchy" problem.
Also, there were a LOT of warnings induced by this upgrade, at least
in the last snapshot I saw, so somebody may also want to look into those
if they're still there.
Thanks!
Jordan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6114.794442750>