Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 16 Mar 1996 04:36:29 -0800
From:      "Jordan K. Hubbard" <jkh@time.cdrom.com>
To:        David Dawes <dawes@rf900.physics.usyd.edu.au>
Cc:        sos@FreeBSD.org, dyson@FreeBSD.org, current@FreeBSD.org, mmead@Glock.COM
Subject:   Re: Try this vm_mmap.c -- please 
Message-ID:  <244.826979789@time.cdrom.com>
In-Reply-To: Your message of "Sat, 16 Mar 1996 21:07:31 %2B1100." <199603161007.VAA09725@rf900.physics.usyd.edu.au> 

next in thread | previous in thread | raw e-mail | index | archive | help
> Does accelx by any chance use MAP_PRIVATE?

Bingo!

Between David's comment here and John's own comment in the latest
vm_mmap.c he sent out which says:

	 * On device mmaps we default to map shared -- makes the most
	 * sense in this case.  Does MAP_PRIVATE even make sense on
	 * devices mmaps???

I made the following change:

	if ((type == OBJT_DEVICE)) {
		if (flags & (MAP_PRIVATE|MAP_SHARED) == 0)
		    flags |= MAP_SHARED;
		else if (flags & MAP_PRIVATE)
		    flags &= ~MAP_PRIVATE;
	}

Which turns MAP_PRIVATE *off* for device objects.  My Xaccel 1.2 now
works perfectly!  Yay!

					Jordan



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?244.826979789>