Date: Wed, 7 Aug 1996 14:35:05 +0930 (CST) From: Michael Smith <msmith@atrad.adelaide.edu.au> To: nate@mt.sri.com (Nate Williams) Cc: Gary.Jennejohn@munich.netsurf.de, msmith@atrad.adelaide.edu.au, freebsd-current@freebsd.org Subject: Re: question about grinding system (Linux guru attn. reqd) Message-ID: <199608070505.OAA19884@genesis.atrad.adelaide.edu.au> In-Reply-To: <199608052100.PAA23721@rocky.mt.sri.com> from "Nate Williams" at Aug 5, 96 03:00:05 pm
next in thread | previous in thread | raw e-mail | index | archive | help
Nate Williams stands accused of saying:
> > >I went looking for M_TEMP allocations in i386/linux, and I'd like someone
> > >who's better qualified than I to look over the exit conditions in
> > >linux_emul_find() in linux_util.c because I'm fairly sure that it's
> > >possible for this function to return without freeing its buffer,
> > >and this would lead to the sort of leak that I'm seeing.
>
> > sure looks like the places where a "goto done" happens fail to free the
> > buffer.
>
> I concur. And, if you look at the sources from the NetBSD OS emulation
> code in /sys/compat/common/compat_util.c, it's even more apparent. The
I managed to get the new code in yesterday evening, and I'm happy to report
that the leak appears to have been plugged :
6:48AM up 19:04, 4 users, load averages: 0.51, 0.42, 0.47
...
Memory statistics by type Type Kern
Type InUse MemUse HighUse Limit Requests Limit Limit Size(s)
namei 0 0K 8K 19661K 6200524 0 0 1K
VM object 707 89K 104K 19661K 7346037 0 0 128
file 81 6K 8K 19661K 1206620 0 0 64
temp 260 221K 431K 19661K 39226630 0 0 16,32,64,128,256,512,1K,2K,8K
I included a couple of the other types above just for comparison's sake;
that class is really getting a pounding 8)
(Note that the load average is down because some of the bacground stuff is
also leaking and was killed off a little while back, it's normally a little
over 1)
Thanks for the patch, Nate.
--
]] Mike Smith, Software Engineer msmith@atrad.adelaide.edu.au [[
]] Genesis Software genesis@atrad.adelaide.edu.au [[
]] High-speed data acquisition and (GSM mobile) 0411-222-496 [[
]] realtime instrument control (ph/fax) +61-8-267-3039 [[
]] Collector of old Unix hardware. "Where are your PEZ?" The Tick [[
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199608070505.OAA19884>