Date: Mon, 2 Dec 1996 11:50:27 +1000 (est) From: Greg Ungerer <gerg@stallion.oz.au> To: Bruce Evans <bde@zeta.org.au> Cc: gerg@stallion.oz.au, hardware@freebsd.org, alex@yahoo.com, bde@zeta.org.au, sos@ravenock.cybercity.dk, sysseh@devetir.qld.gov.au Subject: Re: FreeBSD as Terminal Server Message-ID: <9612021150.aa17922@cluster.stallion.oz.au> In-Reply-To: <199611272236.JAA32072@godzilla.zeta.org.au> from "Bruce Evans" at Nov 28, 96 09:36:12 am
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans writes: > >>You'd need to translate the istallion driver from the Linlish :-). > > > >Huh?? > >What do you mean? > >How mush more FreeBSDish can it be made? > > plainBSDish: use spltty() to disable tty interrupts. Never use > disable_interrupt(), which doesn't exist exist in plainBSD. > > FreeBSDish: use only spltty() as in plainBSD, unless the driver uses > a fast interrupt handler. Sure, but that one thing hardly makes the driver "Linlish". [...stuff about fast interrupts snipped...] > >>I did a quick check for drivers in isa/*.c that abuse disable_intr() > >>and found these: > >> > >>ctx.c: disables interrupts and calls uiomove(). Apart from disabling > >[driver list sniped] > > > >Did you let of the maintainers of these drivers know so they could > >"fix" up the problem? > > These drivers are mostly apparently unmaintained :=]. Well, the Stallion drivers are??? > >In any case this is very easy to "fix" for the Stallion drivers. If you > >look at a lot of the cases of the disabled interrupts they are turned off > >for no more than a couple of dozen instructions... > > Yes, that is safe. To be sure that they are not turned off for longer, > don't call any function outside the driver, since the implementation > of foreign functions is unknown and may change. Foreign functions > may execute thousands of instructions or reenable interrupts. Sure. I have modified the Stallion drivers to only use spltty, and am bench testing them now... Trivial change, code should be available in a few days. Regards Greg --------------------------------------------------------------------------- Greg Ungerer EMAIL: gerg@stallion.com Stallion Technologies Pty Ltd PHONE: +61 7 3270 4271 33 Woodstock Rd, Toowong, QLD 4066, Australia FAX: +61 7 3270 4245
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi? <9612021150.aa17922>