Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 10 Apr 1997 17:27:29 +0400 (MSD)
From:      "Mikhail A. Sokolov" <mishania@demos.su>
To:        proff@suburbia.net
Cc:        hackers@freebsd.org
Subject:   Re: ipfilter-proff backported to 2.2.1
Message-ID:  <199704101327.RAA14530@skraldespand.demos.su>
In-Reply-To: <19970410110853.6196.qmail@suburbia.net> from "proff@suburbia.net" at "Apr 10, 97 09:08:52 pm"

next in thread | previous in thread | raw e-mail | index | archive | help
> Replace src/sys-ipfilter-proff.diff after unpacking the

Succeeded with 2.2.1-R "stock", I just reistalled full sources and made it with
your patch. Though, I have few comments:
In this files, are you sure we want if_var.h included with 2.2.1? Since there's
no <net/if_var.h> in 2.2.1, it should read like 

#include <net/if.h>
#if __FreeBSD_version > 220000
# include <net/if_var.h>
# endif

I.e. it might be good to make it ">", not ">=".

/src/contrib-sys/ipfilter/ip_fil.c	optional ipfilter inet
/src/contrib-sys/ipfilter/fil.c		optional ipfilter inet
/src/contrib-sys/ipfilter/ip_nat.c	optional ipfilter inet
/src/contrib-sys/ipfilter/ip_frag.c	optional ipfilter inet
/src/contrib-sys/ipfilter/ip_state.c	optional ipfilter inet

 As for this line, which finally goes to /sys/compile/MACHINE/, are you sure 
about -nostdinc? See, it fails in make depend, since it can't find simple
things like <stddef.h> etc. I saw it _having_ /usr/src/include and /usr/include,
and /usr/include/sys/ is correctly linked.

+INCLUDES= -nostdinc -I- -I. -I$S -I${.IMPSRC:H}
 # This hack is to allow kernel compiles to succeed on machines w/out srcdist


Now it was only 2 warning about redundant redeclaration of `ipfr_slowtimer` in
ip_frag.h, lines 85 and 47 respectively.

Thanks you, 

-mishania






Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199704101327.RAA14530>