Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 May 1997 09:04:15 +0400 (MSD)
From:      =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= <ache@nagual.pp.ru>
To:        Brian Somers <brian@awfulhak.org>
Cc:        Bruce Evans <bde@zeta.org.au>, brian@FreeBSD.ORG, cvs-all@FreeBSD.ORG, CVS-committers@FreeBSD.ORG, cvs-usrsbin@FreeBSD.ORG
Subject:   Re: cvs commit: src/usr.sbin/ppp timer.c 
Message-ID:  <Pine.BSF.3.96.970510090252.2672A-100000@nagual.pp.ru>
In-Reply-To: <199705100447.FAA10327@awfulhak.demon.co.uk>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 10 May 1997, Brian Somers wrote:

> > >>   Modified:    usr.sbin/ppp  timer.c
> > >>   Log:
> > >>   Set setitimer() arg correctly.
> > >
> > >This commit not needed, read man setitimer.
> > 
> > Actually it is, read the kernel source :-).  The kernel checks the interval
> > even when it doesn't use it and fails without doing anything if the interval
> > is garbage (tv_sec < 0 || tv_sec > 10^8 || tv_usec < 0 || tv_usec >= 10^6).
> 
> Should I fix kern/kern_time.c then ?

I think that 1) kern_time.c needs fixing, 2) let timer.c code stay
as is now to be compatible with other systems possible buggy setitimer()
implementations...

-- 
Andrey A. Chernov
<ache@null.net>
http://www.nagual.pp.ru/~ache/




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.96.970510090252.2672A-100000>