Date: Fri, 25 Jul 1997 13:30:53 +0900 From: itojun@itojun.org To: dg@root.com Cc: hackers@freebsd.org Subject: Re: odd xxget() in some network drivers Message-ID: <18562.869805053@itojun.csl.sony.co.jp> In-Reply-To: David Greenman <dg@root.com>'s message of Thu, 24 Jul 1997 21:24:54 -0700. <199707250424.VAA16538@implode.root.com> References: <199707250424.VAA16538@implode.root.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> The new logic in that PR is:
> ! if (MHLEN < len) {
> The only problem with the above is that the first if () expression is wrong.
>The test should be if (len > MHLEN). Not only is this correct for style, but
>it is logically different: MHLEN < len will allocate an mbuf cluster when
>len == MHLEN, and this is not desired.
???? I did not write MHLEN <= len. Why len>MHLEN and MHLEN<len
should result in different situation?
>> - could I make some check for other drivers, and apply patches if
>> necessery?
> I would prefer that you had your proposed changes reviewed first.
I prefer that too, however only very few people seems to check
problem reports in a regular basis... I do need to wait almost
forever. <sigh>
itojun
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?18562.869805053>