Date: Wed, 24 Sep 1997 02:29:11 +0400 (MSD) From: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= <ache@nagual.pp.ru> To: Brian Somers <brian@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-usrsbin@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/ppp modem.c Message-ID: <Pine.BSF.3.96.970924021826.7008A-100000@lsd.relcom.eu.net> In-Reply-To: <199709232209.PAA03564@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 23 Sep 1997, Brian Somers wrote: > brian 1997/09/23 15:09:46 PDT > > Modified files: (Branch: RELENG_2_2) > usr.sbin/ppp modem.c > Log: > MFC: Don't use uu_lock in -direct mode. It conflicts w/ > hylafax & the like. Early or later you'll return to model I describe: treat -direct as stdin/stdout only without any additional assumptions :-) It seems that hylafax lock modem before open (like any soft who open modem). Moreover some soft can use its own tty modes for opened modem which ppp may spam by CLOCAL set. Imagine f.e. that some upper level soft open device as controlling terminal (assuming he got HUP or -1 from it on carrier drop) then pass descriptor to ppp stdin. ppp spams tty modes by its own CLOCAL, causing upper level soft never got HUP. I think ppp must not touch tty flags of passed descriptor as possible. F.e. setting RAW mode is acceptable thing, but setting/removing HUP handling is not acceptable. Then use both HUP catch function and TIOCM_CD to handle carrier with fallback to carrier_always_ON if TIOCM_CD returns -1. -- Andrey A. Chernov <ache@null.net> http://www.nagual.pp.ru/~ache/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.96.970924021826.7008A-100000>