Date: Tue, 03 Feb 1998 10:01:38 -0800 From: Amancio Hasty <hasty@rah.star-gate.com> To: Luigi Rizzo <luigi@labinfo.iet.unipi.it> Cc: multimedia@FreeBSD.ORG Subject: Re: bt848 feedback... Message-ID: <199802031801.KAA00466@rah.star-gate.com> In-Reply-To: Your message of "Tue, 03 Feb 1998 16:03:18 %2B0100." <199802031503.QAA06191@labinfo.iet.unipi.it>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, Will move the code down the code next time I commit the driver . Cheers, Amancio > In the latest release of the Bt848 code, I noticed the BT848_I2CWR > ioctl that I submitted some time ago has been put in video_ioctl(), > but it really belongs in tuner_ioctl() , where other I2C devices are > also accessed. > > It's just a matter of moving the block in the other function (and > moving the variable declarations at the beginning of video_ioctl, > a hundred lines above... what was wrong with declaring variables > within the block they are used, as in the patch I submitted!). > > Oh btw the code works perfectly on 2.2.1 > > cheers > luigi > -----------------------------+-------------------------------------- > Luigi Rizzo | Dip. di Ingegneria dell'Informazione > email: luigi@iet.unipi.it | Universita' di Pisa > tel: +39-50-568533 | via Diotisalvi 2, 56126 PISA (Italy) > fax: +39-50-568522 | http://www.iet.unipi.it/~luigi/ > _____________________________|______________________________________
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199802031801.KAA00466>