Date: Wed, 11 Feb 1998 12:07:12 -0800 From: David Greenman <dg@root.com> To: dyson@FreeBSD.ORG Cc: jwd@unx.sas.com (John W. DeBoskey), freebsd-current@FreeBSD.ORG Subject: Re: Possible BUG in vfs_bio.c/brelse() line 643 Message-ID: <199802112007.MAA21506@implode.root.com> In-Reply-To: Your message of "Wed, 11 Feb 1998 14:50:51 EST." <199802111950.OAA10458@dyson.iquest.net>
next in thread | previous in thread | raw e-mail | index | archive | help
>John W. DeBoskey said: >> Hi, >> >> I believe the following is a bug in vfs_bio.c/brelse() version 1.147 >> and the following change should be committed. >> >> 643c643 >> < if (bp->b_flags && (B_INVAL | B_RELBUF)) >> --- >> > if (bp->b_flags & (B_INVAL | B_RELBUF)) >> >> I always did like those if (1) conditions. >> >> Comments? Critiques? >> >&& in this case is very bad. I cannot make the change, but whomever >has commit privs, and can do it right now, should change the && to &. Fixed. -DG David Greenman Core-team/Principal Architect, The FreeBSD Project To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199802112007.MAA21506>