Date: Mon, 01 Jun 1998 01:03:59 -0500 From: Jacques Vidrine <n@nectar.com> To: Bruce Evans <bde@zeta.org.au> Cc: freebsd-current@FreeBSD.ORG Subject: Re: union nethostaddr no longer defined for src/sbin/mount_nfs.c Message-ID: <199806010603.BAA27766@cerebus.nectar.com> In-Reply-To: <199806010524.PAA09745@godzilla.zeta.org.au> References: <199806010524.PAA09745@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- You'd have to also back out revision 1.27 of src/sbin/mount_nfs.c of the same date. If a structure needs to be visible to userland utilities, it shouldn't be in a KERNEL section, IMHO. For that matter, I sometimes think there ought to be more header.h/headervar.h pairs instead of #ifdef KERNEL everywhere. I guess the question in my mind is which is more important with regards to the NFS code: * Progress towards a less ``polluted'' environment, OR * Kernel and header source code compatibility with other BSD systems Jacques Vidrine <n@nectar.com> On 1 June 1998 at 15:24, Bruce Evans <bde@zeta.org.au> wrote: > Just back out the part that clobbered this: > > RCS file: /home/ncvs/src/sys/nfs/nfs.h,v > Working file: nfs.h > head: 1.40 > ... > ---------------------------- > revision 1.33 > date: 1998/02/01 21:23:29; author: bde; state: Exp; lines: +15 -15 > Moved declaration of `union nethostadr' outside of the KERNEL section, > to give pollution compatible with <nfs/nqfs.h>. At least mount_nfs.c > previously had to #define KERNEL before including <nfs/nfs.h> to get > this pollution, but this gave other pollution. > > Moved comment about NFSINT_SIGMASK to immediately before the code that > it applies to. > ---------------------------- > > Bruce -----BEGIN PGP SIGNATURE----- Version: 2.6.2 iQCVAwUBNXJETjeRhT8JRySpAQFzvgP/UXtSluOw+crdO3FLiQtpwwXEmQ9mJ2si CIALrmTFCWSx/fxMl0+ZffD5NDltnbRW9kE/wOR/+INeFj0QmerwZO1KiYrfGxJC 7TgiPKQx0ldg4g4z4Cqb5YkWOZf98oi0TWmTzlv1uKH0Jp0Bak9OjgjJOXMDUWgm b6hPagix6i0= =xcLV -----END PGP SIGNATURE----- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199806010603.BAA27766>