Date: Thu, 16 Jul 1998 16:54:16 -0600 From: Warner Losh <imp@village.org> To: John Birrell <jb@cimlogic.com.au> Cc: current@FreeBSD.ORG Subject: Re: Proposed fix for ___error problem. Message-ID: <199807162254.QAA14657@harmony.village.org> In-Reply-To: Your message of "Fri, 17 Jul 1998 07:41:20 %2B1000." <199807162141.HAA17349@cimlogic.com.au> References: <199807162141.HAA17349@cimlogic.com.au>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <199807162141.HAA17349@cimlogic.com.au> John Birrell writes:
: I haven't tried putting buildworld before the -m argument, but from what
: I see in your message, the "-m /usr/src/share/mk" isn't getting the correct
: includes. No patches are necessary if you use the correct command.
: The __error problem indicates that /usr/lib is being used instead of
: /usr/lib/aout because the top level makefile is using an old sys.mk.
What failed was "sudo make -m share/mk buildworld MACHINE_ARCH=i386".
The -m didn't work for anything except the top level makefile, which
is what lead me to believe there were problems. When I did make -m
share/mk MACHINE_ARCH=i386 -V LIBDIR, it printed the wrong thing.
Just now I did make -m /where/I/have/the/sources/share/mk -V LIBDIR it
printed the right thing.
The tree builds the same with the absolute path w/ or w/o my patches.
This leads me to believe that the -m share/mk (the relative path) is
what caused the problems :-(. Maybe we should check for that somehow
since it is so easy to stubmle over.
Or, as Mrs Yetti Goosecreature used to say "Oh, that's different.
Never mind."
Warner
P.S. The following would have kept me from making this mistake. It
is the check I mentioned above.
Index: Makefile
===================================================================
RCS file: /home/imp/FreeBSD/CVS/src/Makefile,v
retrieving revision 1.205
diff -u -r1.205 Makefile
--- Makefile 1998/07/07 09:59:48 1.205
+++ Makefile 1998/07/16 22:52:34
@@ -233,6 +233,10 @@
# success, regardless of how old your existing system is.
#
buildworld:
+ @(if (echo ${MAKEFLAGS} | egrep -- '-m [^/]' > /dev/null); then \
+ echo "make -m can't have a relative path for world targets" ;\
+ exit 1;\
+ fi)
.if !defined(NOCLEAN)
@echo
@echo "--------------------------------------------------------------"
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199807162254.QAA14657>