Date: Thu, 13 Aug 1998 19:04:03 +0100 (BST) From: Doug Rabson <dfr@nlsystems.com> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, dfr@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_diskslice.c vfs_bio.c vfs_cluster.c src/sys/nfs nfs_vnops.c Message-ID: <Pine.BSF.4.01.9808131901490.2114-100000@herring.nlsystems.com> In-Reply-To: <199808130831.SAA09075@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 13 Aug 1998, Bruce Evans wrote: > > Modified files: > > sys/kern subr_diskslice.c vfs_bio.c vfs_cluster.c > > sys/nfs nfs_vnops.c > > Log: > > Protect all modifications to v_numoutput with splbio(). > > > > Revision Changes Path > > 1.57 +7 -3 src/sys/kern/subr_diskslice.c > > 1.169 +4 -2 src/sys/kern/vfs_bio.c > > 1.68 +3 -1 src/sys/kern/vfs_cluster.c > > 1.106 +2 -2 src/sys/nfs/nfs_vnops.c > > This can't be the right fix. vwakeup() also modifies v_flag, so zillions > of of modifications of v_flag need similar changes. Perhaps keep the VBWAIT > flag and a pending v_numoutput decrement in separate variables to reduce > contention. You are probably right about v_flag needing protection but I have never seen problems that I can trace to v_flag. I got hangs due to v_numoutput corruption regularly. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 951 1891 Fax: +44 181 381 1039
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.01.9808131901490.2114-100000>