Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 20 Aug 1998 22:43:46 -0400 (EDT)
From:      Tim Vanderhoek <ac199@hwcn.org>
To:        Satoshi Asami <asami@FreeBSD.ORG>
Cc:        hoek@hwcn.org, obrien@NUXI.com, ports@FreeBSD.ORG
Subject:   Re: cvs commit: ports/lang/glibstdc++28 Makefile
Message-ID:  <Pine.BSF.3.96.980820221413.1562A-100000@localhost>
In-Reply-To: <199808210207.TAA10850@silvia.hip.berkeley.edu>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 20 Aug 1998, Satoshi Asami wrote:

> We decided to stick it in post-install to give people chances to
> change with the generated file (${TMPPLIST}).  Maybe we can move it
> back to after post-install and add a new target ("post-generate-plist"?)
> for fiddling with it.  Eek.

Essentially that's what TMPPLIST=PLIST does.  It's just a little
draconian!

Perhaps generate-plist: should not consider a non-existent
${PLIST} as an error.  Then fake-pkg: would continue to flag the
error (as it does now).  However, if fake-pkg: found that
${TMPPLIST} did not exist, it would call generate-plist: (for a
total of twice).  This would allow a port to create ${PLIST} at
any time during install, without forcing it to mess with
TMPPLIST.


> Personally I think it can just be solved by having ilu generate PLIST
> in do-install.  All you need to do is to change "post-install:" to
> "do-install:" and add a "cd ${WRKSRC}; ${MAKE} install" in front of
> that target, right?

Yes, although as a matter of style I don't particularly like
redefining the do-* targets unless they're truly being redefined.


Another interesting one is TenDRA.  It reads ${PLIST} to decide
what files to install as part of its do-install target.  If it is
switched to use PLIST_SUB then, with the proposed bsd.port.mk,
its do-install: must either move to post-install: (with a dummy
do-install:... Ugh!) or it needs a do-install: generate-plist
dependency. 

I happen to have already tested the latter solution
(bento:/a/tmp/TenDRA).  :-)


-- 
This .sig is not innovative, witty, or profund.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.96.980820221413.1562A-100000>