Date: Thu, 3 Sep 1998 04:54:07 +0200 (MET DST) From: Luigi Rizzo <luigi@labinfo.iet.unipi.it> To: tlambert@primenet.com (Terry Lambert) Cc: hackers@FreeBSD.ORG Subject: Re: bcmp abuse in networking code ? Message-ID: <199809030254.EAA11546@labinfo.iet.unipi.it> In-Reply-To: <199809030048.RAA01032@usr07.primenet.com> from "Terry Lambert" at Sep 3, 98 00:47:57 am
next in thread | previous in thread | raw e-mail | index | archive | help
> > In my revised bridge code i have the following macros > > #define ETH_MATCH(a,b) ( \ ... > > #define IS_ETHER_BROADCAST(a) ( \ ... > As you noted, alignment is one issue. > > Another issue is the use of arbitrary length addresses in the ARP code. > > See www.daemonnews.org, in the "under the hood" column, where they > talk about implementing precisely this for FDDI and AX.25 support Alignment apart, this time it seems to me that you are mentioning a few not relevant things. The macros above have a clear ETH in the name, they are not meant for some generic link layer of the future which i cannot foresee (and for ARCNET and AX25... can we talk about them when we have support for them ?) If i am not mistaken FDDI has 6-byte addresses so it is not an issue. And i don't understand how ipv6 code could change the ethernet MAC addresses... > in the NetBSD kernel. > > Assumptions about the entry length are bad (IMO), in that they break > future compatability. ok, right now the code uses something like !bcmp(a, b, ETHER_ADDR_LEN) in place of the above macros. i guess they fall into the same category... cheers luigi > > Consider the IPv6 code from WIDE and INRIA, and make sure this change > does not damage the ability to use IPv6 on FreeBSD (for one concrete > case of current, working code, for all you X.25-haters...). > > > Terry Lambert > terry@lambert.org > --- > Any opinions in this posting are my own and not those of my present > or previous employers. > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199809030254.EAA11546>