Date: Sat, 6 Nov 1999 14:25:50 -0500 (EST) From: Brian Fundakowski Feldman <green@FreeBSD.org> To: Dmitrij Tejblum <tejblum@arc.hq.cti.ru> Cc: David Malone <dwmalone@maths.tcd.ie>, Ollivier Robert <roberto@keltia.freenix.fr>, FreeBSD Current Users' list <freebsd-current@FreeBSD.ORG> Subject: Re: Serious locking problem in CURRENT Message-ID: <Pine.BSF.4.10.9911061424020.54344-100000@green.myip.org> In-Reply-To: <199911061921.WAA02732@tejblum.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 6 Nov 1999, Dmitrij Tejblum wrote: > David Malone wrote: > > A child process seems to be able to let go of a parent's lock on > > 4.0 by closing a file discriptor, the same doesn't seem to be true > > on 3.3. > > So, apparently, it was broken in rev. 1.68 of kern_descript.c. (Another > example that comments (in closef() in this case) serve no purpose :-/). There were zero comments about what order things happen in; in fact, the ordering in this case is Just Plain Lame (TM). It's much more correct to explicitly check for fp->f_count == 1. > > BTW, I have another little concern with that commit: It make possible for > last close() of a file descriptor to return 0 instead of the error from > VOP_CLOSE(), and the error from VOP_CLOSE() to be ignored. I don't see where you're getting that from at all. > > Dima > > > -- Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! / green@FreeBSD.org `------------------------------' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.9911061424020.54344-100000>