Date: Fri, 14 Feb 2025 14:30:02 -0700 From: "Janky Jay, III" <jankyj@unfs.us> To: ports@freebsd.org Subject: Re: New www/snip Port. Message-ID: <c33a3606-44b6-409b-b3db-65c0045774bf@unfs.us> In-Reply-To: <1ee7bfa2-901b-4847-be88-432e2e974fed@protonmail.com> References: <b5fccc0f-d871-4c41-aff1-6ddace305dc8@unfs.us> <1ee7bfa2-901b-4847-be88-432e2e974fed@protonmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------P7xFIZqOeQIdwNhA3EHyEbzN
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Hi, Yusuf.
On 2/14/25 05:26AM, Yusuf Yaman wrote:
>
> Hi,
>
> I don't have experience with php ports i do have some basic porting
> knowledge. I tried to improve the port and sent them to the PR report.
>
> I edited git commit message.
> I used port tools (portclippy,portfmt,portlint) to improve the port.
> I made use of OPT_USE instead of ${PORT_OPTIONS}.
> I changed portname to match github project name.
>
> I'll also attach the diff so you can better see what I changed.
>
> I tested it in poudriere 14.2-R amd64 and testport is fine, didn't test if it works fine, though.
Excellent. Thank you very much, and approved!
Regards,
Janky Jay, III
--------------P7xFIZqOeQIdwNhA3EHyEbzN
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit
<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
Hi, Yusuf.<br>
<br>
<div class="moz-cite-prefix">On 2/14/25 05:26AM, Yusuf Yaman wrote:<br>
</div>
<blockquote type="cite"
cite="mid:1ee7bfa2-901b-4847-be88-432e2e974fed@protonmail.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<p>Hi,<br>
<br>
I don't have experience with php ports i do have some basic
porting knowledge. I tried to improve the port and sent them to
the PR report.<br>
</p>
<pre class="bz_comment_text" id="comment_text_9">I edited git commit message.
I used port tools (portclippy,portfmt,portlint) to improve the port.
I made use of OPT_USE instead of ${PORT_OPTIONS}.
I changed portname to match github project name.
I'll also attach the diff so you can better see what I changed.
I tested it in poudriere 14.2-R amd64 and testport is fine, didn't test if it works fine, though.</pre>
</blockquote>
Excellent. Thank you very much, and approved!<br>
<br>
Regards,<br>
Janky Jay, III<br>
</body>
</html>
--------------P7xFIZqOeQIdwNhA3EHyEbzN--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c33a3606-44b6-409b-b3db-65c0045774bf>