Date: Thu, 16 Mar 2000 04:37:58 +0900 From: "Daniel C. Sobral" <dcs@newsguy.com> To: Soren Schmidt <sos@freebsd.dk> Cc: "Daniel C. Sobral" <dcs@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/boot/i386/libi386 biosdisk.c Message-ID: <38CFE696.22F7EF3E@newsguy.com> References: <200003151152.MAA70295@freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
Soren Schmidt wrote:
>
> You could have tested it before committing it, it looks totally bogus:
>
> cc -O -pipe -I/u1/src/sys/boot/i386/libi386/../../common -I/u1/src/sys/boot/i386/libi386/../btx/lib -I/u1/src/sys/boot/i386/libi386/../../.. -I. -DCOMPORT=0x3f8 -DCOMSPEED=9600 -DTERM_EMU -c /u1/src/sys/boot/i386/libi386/biosdisk.c -o biosdisk.o
> /u1/src/sys/boot/i386/libi386/biosdisk.c: In function `bd_print':
> /u1/src/sys/boot/i386/libi386/biosdisk.c:242: syntax error before `,'
> /u1/src/sys/boot/i386/libi386/biosdisk.c:289: case label not within a switch statement
> /u1/src/sys/boot/i386/libi386/biosdisk.c:293: default label not within a switch statement
> /u1/src/sys/boot/i386/libi386/biosdisk.c: At top level:
> /u1/src/sys/boot/i386/libi386/biosdisk.c:301: syntax error before `}'
> ..
> ..
For those curious about it, I applied a patch generated locally to the
file on my freefall account. The later had been spammed a couple of
months ago, and I had forgotten about it (and I don't delete that tree,
since it has some changes so that it can test-compile current's loader
on freefall -- which I did not do, since it went through heavy testing
locally).
Frankly, it was so bogus I do not understand why someone didn't simply
fix it.
--
Daniel C. Sobral (8-DCS)
dcs@newsguy.com
dcs@freebsd.org
One Unix to rule them all, One Resolver to find them,
One IP to bring them all and in the zone bind them.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?38CFE696.22F7EF3E>